Add example - #791
Add example#791
Conversation
* adds example for Feurer et al. (2015) * removes the stub for Fusi et al. (2018) as they actually perform the same task. I can't create an example, though, as they used regression datasets for classification (and OpenML by now forbids creating such tasks).
Codecov Report
@@ Coverage Diff @@
## develop #791 +/- ##
===========================================
- Coverage 87.71% 87.68% -0.03%
===========================================
Files 36 36
Lines 4208 4248 +40
===========================================
+ Hits 3691 3725 +34
- Misses 517 523 +6
Continue to review full report at Codecov.
|
| ] | ||
|
|
||
| #################################################################################################### | ||
| # The dataset IDs could be used directly to load the dataset and split the data into a training |
There was a problem hiding this comment.
Are you sure you want to start with the dataset ids, rather than the task ids?
If the answer is yes, this clearly signals that we do not have any good procedures for "getting tasks that belong to a given set of datasets". We should either extend the API to support this better or provide the functions below as convenience function (or combination of both)
There was a problem hiding this comment.
The reasoning here is to stay close to the Auto-sklearn paper, where only dataset IDs are given. What kind of convenience function would you like to have? Something like:
def get_tasks_for_dataset(
dataset_id: int,
task_type_id: int,
estimation_procedure: str,
status: str,
check_target_attribute: bool,
) -> List:
pass
There was a problem hiding this comment.
I will also make the note more drastic.
| # deactivated tasks | ||
| tasks_d = openml.tasks.list_tasks( | ||
| task_type_id=1, | ||
| status='deactivated', |
There was a problem hiding this comment.
why not search for status "all" ?
There was a problem hiding this comment.
Lack of knowledge, I'll update the example.
| task_ids.sort() | ||
|
|
||
| # These are the tasks to work with: | ||
| print(task_ids) |
There was a problem hiding this comment.
I think print is fine for examples. logging is only important for the library itself to make the amount of output controllable.
janvanrijn
left a comment
janvanrijn
left a comment
There was a problem hiding this comment.
Looks good, I could not find anything big.
|
Thanks for the review, I hope I could address your comments. |
|
|
||
| | Efficient and Robust Automated Machine Learning | ||
| | Matthias Feurer, Aaron Klein, Katharina Eggensperger, Jost Springenberg, Manuel Blum and Frank Hutter | ||
| | Matthias Feurer, Aaron Klein, Katharina Eggensperger, Jost Springenberg, Manuel Blum and Frank Hutter # noqa F401 |
There was a problem hiding this comment.
@mfeurer wrong usage of # noqa F401 in the text ? It is not interpreted as a comment.
Maybe you meant here:
| ] | ||
|
|
||
| #################################################################################################### | ||
| # The dataset IDs could be used directly to load the dataset and split the data into a training |
| # It is discouraged to work directly on datasets and only provide dataset IDs in a paper as | ||
| # this does not allow reproducibility (unclear splitting). Please do not use datasets but the | ||
| # respective tasks as basis for a paper and publish task IDS. This example is only given to | ||
| # showcase the use OpenML-Python for a published paper and as a warning on how not to do it. |
4 participants
same task. I can't create an example, though, as they used regression
datasets for classification (and OpenML by now forbids creating such
tasks).