Add new convenience function get_flow_id - #792
Merged
Merged
Conversation
mfeurer
requested review from
ArlindKadra,
amueller,
janvanrijn and
joaquinvanschoren
October 1, 2019 14:32
Codecov Report
@@ Coverage Diff @@
## develop #792 +/- ##
===========================================
- Coverage 87.71% 87.67% -0.04%
===========================================
Files 36 36
Lines 4208 4228 +20
===========================================
+ Hits 3691 3707 +16
- Misses 517 521 +4
Continue to review full report at Codecov.
|
ArlindKadra
reviewed
Oct 6, 2019
ArlindKadra
left a comment
ArlindKadra
left a comment
Member
There was a problem hiding this comment.
Just a few minor comments, everything looks good :)
ArlindKadra
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds:
get_flow_idReason
Replaces:
openml.extensions.get_extension_by_model(clf).model_to_flow(clf).publish().flow_idby
openml.flows.get_flow_id(model=clf)and also allows to query for all flows of a given model across all external versions:
openml.flows.get_flow_id(model=clf, exact_version=False)