Repository navigation
added example strang, and more filter options - #793
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #793 +/- ##
===========================================
+ Coverage 87.71% 87.73% +0.01%
===========================================
Files 36 36
Lines 4208 4214 +6
===========================================
+ Hits 3691 3697 +6
Misses 517 517
Continue to review full report at Codecov.
|
mfeurer
requested changes
Oct 2, 2019
mfeurer
left a comment
mfeurer
left a comment
Collaborator
There was a problem hiding this comment.
Amazingly simple, I really like this example!
Only a few very minor comments.
mfeurer
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this PR implement/fix? Explain your changes.
How should this PR be tested?
Any other comments?