CONSOLE-4598: Migrate enzyme __tests__/components/utils unit tests to React Testing… by cajieh · Pull Request #15442 · openshift/console

cajieh · 2025-08-28T15:53:46Z

No description provided.

openshift-ci-robot · 2025-08-28T15:53:50Z

@cajieh: This pull request references CONSOLE-4598 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

… Library

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2025-09-02T11:15:51Z

/retest

openshift-ci-robot · 2025-09-02T11:47:19Z

@cajieh: This pull request references CONSOLE-4598 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cajieh · 2025-09-02T20:17:58Z

/test frontend

cajieh · 2025-09-04T13:13:42Z

/test frontend

logonoff

/label px-approved
/label docs-approved

logonoff · 2025-09-05T13:11:32Z

+jest.mock('../../../components/utils/status-box', () => ({
+  LoadingBox: () =>
+    require('react').createElement('div', { 'data-test': 'loading-box' }, 'Loading...'),
+}));


i think it would be a bit cleaner to just return a string and detect for this text instead of checking a testid

Suggested change

jest.mock('../../../components/utils/status-box', () => ({

LoadingBox: () =>

require('react').createElement('div', { 'data-test': 'loading-box' }, 'Loading...'),

}));

jest.mock('../../../components/utils/status-box', () => ({

LoadingBox: () => "Loading..."

}));

logonoff · 2025-09-05T13:12:56Z

+jest.mock('react-i18next', () => ({
+  withTranslation: () => (Component) => {
+    const WrappedComponent = (props) => {
+      const t = (key) => key.split('~')[1] || key;
+      return require('react').createElement(Component, { ...props, t });
+    };
+    WrappedComponent.displayName = `withTranslation(${Component.displayName || Component.name})`;
+    return WrappedComponent;
+  },
+  useTranslation: () => ({
+    t: (key) => key.split('~')[1] || key,
+  }),
+}));


i'd recommend we use the same mocks as we usually do without needing to require react

Suggested change

jest.mock('react-i18next', () => ({

withTranslation: () => (Component) => {

const WrappedComponent = (props) => {

const t = (key) => key.split('~')[1] || key;

return require('react').createElement(Component, { ...props, t });

};

WrappedComponent.displayName = `withTranslation(${Component.displayName || Component.name})`;

return WrappedComponent;

},

useTranslation: () => ({

t: (key) => key.split('~')[1] || key,

}),

}));

jest.mock('react-i18next', () => ({

useTranslation: () => ({

t: (key: string) => key,

}),

withTranslation: () => (Component: any) => Component,

}));

Did you try this change? It appears not to work because withTranslation HOC is designed to inject the t function as a prop into the wrapped component.

I did not try this change with this test suite specifically; however, this mock is already used by several other unit tests

… Library

logonoff

/lgtm

cajieh · 2025-09-05T15:00:17Z

QE Approver:
/assign @yapei

yapei · 2025-09-08T06:25:41Z

/retest-required

cajieh · 2025-09-08T17:26:52Z

/test frontend

yapei · 2025-09-09T00:36:45Z

frontend test is still failing....

cajieh · 2025-09-09T20:15:30Z

/test frontend

yapei · 2025-09-10T01:10:03Z

 import { Map as ImmutableMap } from 'immutable';

-export { PodModel } from '../../../models';
+export { PodModel, ServiceModel } from '../../../models';


what is this changed targeted for?

what is this changed targeted for?

Oh, that wasn't needed. Removed it. Thanks for the catch!

yapei · 2025-09-10T06:19:58Z

/retest-required

yapei · 2025-09-10T11:24:42Z

/retest-required

yapei · 2025-09-10T11:25:17Z

frontend is passing before the last commit
/verified by @yapei

openshift-ci-robot · 2025-09-10T11:25:34Z

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

frontend is passing before the last commit
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-09-10T13:13:03Z

/label qe-approved
/lgtm

openshift-ci-robot · 2025-09-10T13:13:12Z

@cajieh: This pull request references CONSOLE-4598 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-09-10T13:13:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [cajieh,logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-09-10T15:59:26Z

/retest-required

Remaining retests: 0 against base HEAD 343b6dd and 2 for PR HEAD 20fe530 in total

openshift-ci · 2025-09-10T16:24:50Z

@cajieh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`20fe530`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2025

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2025

openshift-ci Bot requested review from TheRealJon and spadgett August 28, 2025 15:54

openshift-ci Bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2025

cajieh force-pushed the migrate-enzyme-__tests__-components-utils-unit-tests-rtl branch 3 times, most recently from 57ff13e to 09aed35 Compare September 2, 2025 10:46

cajieh force-pushed the migrate-enzyme-__tests__-components-utils-unit-tests-rtl branch from 09aed35 to d5ae638 Compare September 2, 2025 11:37

cajieh force-pushed the migrate-enzyme-__tests__-components-utils-unit-tests-rtl branch 4 times, most recently from c397474 to bc783fe Compare September 4, 2025 07:42

cajieh force-pushed the migrate-enzyme-__tests__-components-utils-unit-tests-rtl branch 2 times, most recently from fd20554 to 4b0f530 Compare September 4, 2025 13:45

cajieh changed the title ~~[WIP] CONSOLE-4598: Migrate enzyme __tests__/components/utils unit tests to React Testing…~~ CONSOLE-4598: Migrate enzyme __tests__/components/utils unit tests to React Testing… Sep 4, 2025

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2025

logonoff reviewed Sep 5, 2025

View reviewed changes

openshift-ci Bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 5, 2025

Migrate enzyme __tests__/components/utils unit tests to React Testing…

9905587

… Library

cajieh force-pushed the migrate-enzyme-__tests__-components-utils-unit-tests-rtl branch from 4b0f530 to 9905587 Compare September 5, 2025 14:24

logonoff approved these changes Sep 5, 2025

View reviewed changes

openshift-ci Bot assigned logonoff Sep 5, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025

openshift-ci Bot assigned yapei Sep 5, 2025

yapei reviewed Sep 10, 2025

View reviewed changes

update

20fe530

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 10, 2025

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Sep 10, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025

openshift-merge-bot Bot merged commit 05f0ab3 into openshift:main Sep 10, 2025
7 of 8 checks passed

Uh oh!

Conversation

cajieh commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 28, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cajieh commented Sep 2, 2025

Uh oh!

openshift-ci-robot commented Sep 2, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cajieh commented Sep 2, 2025

Uh oh!

cajieh commented Sep 4, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

logonoff Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

cajieh Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

cajieh commented Sep 5, 2025

Uh oh!

yapei commented Sep 8, 2025

Uh oh!

cajieh commented Sep 8, 2025

Uh oh!

yapei commented Sep 9, 2025

Uh oh!

cajieh commented Sep 9, 2025

Uh oh!

yapei Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

cajieh Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

yapei commented Sep 10, 2025

Uh oh!

yapei commented Sep 10, 2025

Uh oh!

yapei commented Sep 10, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

logonoff commented Sep 10, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 10, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

openshift-ci Bot commented Sep 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cajieh commented Aug 28, 2025 •

edited

Loading

openshift-ci-robot commented Aug 28, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Sep 2, 2025 •

edited by openshift-ci Bot

Loading

cajieh Sep 5, 2025 •

edited

Loading

logonoff Sep 5, 2025 •

edited

Loading

openshift-ci-robot commented Sep 10, 2025 •

edited by openshift-ci Bot

Loading