Skip to content

CNTRLPLANE-4538: correct August report blog attribution - #9931

Merged
celebdor merged 1 commit into
openshift:mainfrom
celebdor:docs/august-blog-attribution
Oct 14, 2026
Merged

celebdor merged 1 commit into
openshift:mainfrom
celebdor:docs/august-blog-attribution

Conversation

@celebdor

@celebdor celebdor commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Corrects the August progress report attribution for the dual-stream RHEL work and makes several small editorial corrections.

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-4538

Special notes for your reviewer:

The report now credits sdminonne for the foundational NodePool controller plumbing in PR #8730 and the OCP 5.0 RHCOS parsing fix included in PR #9033. It also removes a duplicate linter entry, fixes Karpenter wording, and clarifies the summary metrics.

Validation: make docs-aggregate; git diff --check.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • Documentation
    • Updated the progress report to clarify OSStreams controller and test coverage, including RHCOS version parsing and upgrade paths.
    • Revised the Karpenter feature-gate warning to note that inline management remains the default until standalone mode is validated at scale.
    • Updated the linter section and renamed metrics table categories to “Featured stories” and “Breaking API changes.”

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 7, 2026 •

Copy link
Copy Markdown

@celebdor: This pull request references CNTRLPLANE-4538 which is a valid jira issue.

Details

In response to this:

What this PR does / why we need it:

Corrects the August progress report attribution for the dual-stream RHEL work and makes several small editorial corrections.

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-4538

Special notes for your reviewer:

The report now credits sdminonne for the foundational NodePool controller plumbing in PR #8730 and the OCP 5.0 RHCOS parsing fix included in PR #9033. It also removes a duplicate linter entry, fixes Karpenter wording, and clarifies the summary metrics.

Validation: make docs-aggregate; git diff --check.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Oct 7, 2026
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 98fa3c2d-626d-486e-a1ad-eeca083dd733
📥 Commits

Reviewing files that changed from the base of the PR and between 677a841 and c364525.

📒 Files selected for processing (1)
  • docs/content/blog/2026-08-progress-report.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The progress report updates its OSStreams summary to describe NodePool wiring and OCP 5.0 RHCOS version parsing and upgrade-path coverage. It clarifies the Karpenter warning, removes an explanatory linter note, and renames two metrics table headings.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c3645

The report’s attribution is consistent with the recorded July 10 merge date. No concrete merge-blocking issue remains in the supplied documentation changes.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only docs/content/blog/2026-08-progress-report.md. The diff contains editorial report text and metrics; it does not change Ginkgo test declarations or test titles. The stable-test-nam…
Test Structure And Quality ✅ Passed The pull-request diff changes only docs/content/blog/2026-08-progress-report.md. It adds or edits report text and metrics; it does not change Ginkgo test code. The test-structure criteria therefore …
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only docs/content/blog/2026-08-progress-report.md. Its edits update report attribution and wording; they do not add or modify deployment manifests, operator code, controller…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only docs/content/blog/2026-08-progress-report.md. The diff contains editorial changes and adds no Ginkgo tests, so this check does not apply.
No-Weak-Crypto ✅ Passed The pull request changes only docs/content/blog/2026-08-progress-report.md. The diff contains editorial and metrics updates, with no weak-crypto usage, custom crypto implementation, or secret/token …
Container-Privileges ✅ Passed The pull request changes only docs/content/blog/2026-08-progress-report.md. Its diff contains editorial text changes and does not modify container or Kubernetes manifests or introduce any listed pri…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only docs/content/blog/2026-08-progress-report.md. The additions are report prose, contributor links, PR references, and summary metrics; they do not add logging code or exp…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: correcting attribution in the August progress report. It is concise and related to the documented changes.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@celebdor celebdor changed the title CNTRLPLANE-4538: correct August report attribution CNTRLPLANE-4538: correct August report blog attribution Oct 7, 2026
@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
github-actions Bot temporarily deployed to docs-preview/pr-9931 October 7, 2026 13:37 Inactive
@celebdor
celebdor force-pushed the docs/august-blog-attribution branch from c364525 to c507b64 Compare October 7, 2026 13:39
@openshift-ci openshift-ci Bot added the area/documentation Indicates the PR includes changes for documentation label Oct 7, 2026
@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celebdor
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Credit sdminonne for the dual-stream controller implementation and OCP 5.0 parsing fix. Clarify related report wording and metrics.
@celebdor
celebdor force-pushed the docs/august-blog-attribution branch from c507b64 to e3a4f45 Compare October 7, 2026 13:41
@celebdor
celebdor marked this pull request as ready for review October 8, 2026 15:19
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2026
@openshift-ci

openshift-ci Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@celebdor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cblecker

Copy link
Copy Markdown
Member

/uncc

@openshift-ci
openshift-ci Bot removed the request for review from cblecker October 10, 2026 07:07
@celebdor
celebdor merged commit 3659d94 into openshift:main Oct 14, 2026
22 of 24 checks passed
@celebdor
celebdor deleted the docs/august-blog-attribution branch October 14, 2026 12:22

This branch was successfully deployed

1 active deployment
docs-preview/pr-9931 — e3a4f457 Deployed Oct 7, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants