OSDOCS#4112[OPECO][4.14] Multi-arch support for Operator projects by michaelryanpeter · Pull Request #64355 · openshift/openshift-docs

michaelryanpeter · 2023-09-05T22:20:03Z

Version(s): 4.14

Issue: OSDOCS-4112

Link to docs preview: Configuring Operator projects to support multiple architectures and operating systems

QE review:

QE has approved this change.

Additional information:

ocpdocs-previewbot · 2023-09-05T23:04:31Z

🤖 Updated build preview is available at:
https://64355--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27183

jaypoulz

OK so I've left comments on the overall skeleton and provided extra context where I could.

Overall, this is already looking very good. I didn't have a chance to run through it with an example operator, but I will try to get to that early next week.

michaelryanpeter · 2023-09-15T19:15:25Z

@aleskandro and @jaypoulz I'm sorry for not responding to all of your feedback yet. I had some bugs come up that needed to be addressed. I have also needed to process some of the comments to adjust the information architecture of the content. I will reach out if I get blocked on anything. Thanks for your help!

jaypoulz

Review is still in progress. I will pick up where I left off starting with the changes in osdk-multi-arch-node-affinity.adoc

michaelryanpeter · 2023-09-29T23:51:50Z

@jaypoulz and @everettraven I have reorganized the content based on both of your comments.

In particular, I simplified the procedure for making a manifest list, removing the steps where I unintentionally repeated myself. I removed the skopeo related content, as well. Since the Operator SDK uses docker buildx, it seemed distracting to bounce between tools.

I also moved the validation procedure to the Bundle validate section of the docs. Lastly, I decided to link out to the procedure on adding labels to the Operator's CSV. That module needs to be rewritten to conform with this new content, and I am not going to be able to get to that before GA.

aleskandro · 2023-10-03T12:44:38Z

/label qe-approved

jaypoulz

/lgtm

openshift-ci · 2023-10-06T00:35:16Z

New changes are detected. LGTM label has been removed.

michaelryanpeter · 2023-10-06T00:51:05Z

/label peer-review-needed

skopacz1 · 2023-10-06T12:46:32Z

/label peer-review-in-progress

skopacz1

Left some comments, but looks good to me!

skopacz1 · 2023-10-06T15:16:56Z

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

skopacz1

A few more comments, let me know what you think!

michaelryanpeter · 2023-10-09T18:13:29Z

/cherrypick enterprise-4.14

openshift-cherrypick-robot · 2023-10-09T18:14:16Z

@michaelryanpeter: new pull request created: #65961

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelryanpeter added the branch/enterprise-4.14 label Sep 5, 2023

michaelryanpeter added this to the Planned for 4.14 GA milestone Sep 5, 2023

openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2023

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch from 21ad1cd to 69c712e Compare September 6, 2023 19:13

michaelryanpeter commented Sep 6, 2023

View reviewed changes

Comment thread operators/operator_sdk/osdk-multi-arch-support.adoc Resolved

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch from 69c712e to 717cb3e Compare September 6, 2023 19:31

jaypoulz reviewed Sep 8, 2023

View reviewed changes

Comment thread operators/operator_sdk/osdk-multi-arch-support.adoc Resolved

jaypoulz reviewed Sep 8, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-node-affinity.adoc Resolved

jaypoulz reviewed Sep 8, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-validate.adoc Resolved

jaypoulz reviewed Sep 8, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-node-affinity.adoc Resolved

jaypoulz reviewed Sep 11, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-node-affinity.adoc Resolved

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch from 11fca67 to ebbc283 Compare September 11, 2023 19:48

aleskandro reviewed Sep 13, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-node-affinity.adoc Resolved

Comment thread modules/osdk-multi-arch-node-affinity.adoc Resolved

Comment thread modules/osdk-multi-arch-node-affinity.adoc Resolved

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 3 times, most recently from 53531f9 to 3e15a33 Compare September 28, 2023 23:12

jaypoulz suggested changes Sep 29, 2023

View reviewed changes

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 2 times, most recently from 28ae7e5 to 456179e Compare September 29, 2023 23:47

jaypoulz reviewed Oct 2, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-building-images.adoc Resolved

michaelryanpeter commented Oct 2, 2023

View reviewed changes

Comment thread operators/operator_sdk/osdk-multi-arch-support.adoc Resolved

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Oct 3, 2023

everettraven reviewed Oct 3, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-building-images.adoc Resolved

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 3 times, most recently from 6cda9df to 78057f6 Compare October 3, 2023 17:24

jaypoulz reviewed Oct 4, 2023

View reviewed changes

Comment thread modules/osdk-multi-arch-validate.adoc Resolved

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 2 times, most recently from d0e842f to 3f60cdc Compare October 5, 2023 16:54

jaypoulz approved these changes Oct 5, 2023

View reviewed changes

openshift-ci Bot assigned jaypoulz Oct 5, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch from 3f60cdc to 2853791 Compare October 6, 2023 00:34

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023

openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 6, 2023

openshift-ci Bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 6, 2023

skopacz1 reviewed Oct 6, 2023

View reviewed changes

openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 6, 2023

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch 3 times, most recently from e179c5d to 1da00a6 Compare October 6, 2023 16:45

skopacz1 reviewed Oct 6, 2023

View reviewed changes

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch from 1da00a6 to 1b3f924 Compare October 9, 2023 16:16

OSDOCS-4112: Multi-arch support for Operator projects

12831f8

michaelryanpeter force-pushed the opeco-4.14-mixed-arch branch from 1b3f924 to 12831f8 Compare October 9, 2023 17:42

michaelryanpeter merged commit 4407caf into openshift:main Oct 9, 2023

openshift-cherrypick-robot mentioned this pull request Oct 9, 2023

[enterprise-4.14] OSDOCS#4112[OPECO][4.14] Multi-arch support for Operator projects #65961

Merged

michaelryanpeter deleted the opeco-4.14-mixed-arch branch October 26, 2023 16:14

Conversation

michaelryanpeter commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaypoulz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelryanpeter commented Sep 15, 2023

Uh oh!

jaypoulz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelryanpeter commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aleskandro commented Oct 3, 2023

Uh oh!

Uh oh!

Uh oh!

jaypoulz left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Oct 6, 2023

Uh oh!

michaelryanpeter commented Oct 6, 2023

Uh oh!

skopacz1 commented Oct 6, 2023

Uh oh!

skopacz1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skopacz1 commented Oct 6, 2023

Uh oh!

skopacz1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelryanpeter commented Oct 9, 2023

Uh oh!

openshift-cherrypick-robot commented Oct 9, 2023

Uh oh!

Reviewers

Uh oh!

michaelryanpeter commented Sep 5, 2023 •

edited

Loading

ocpdocs-previewbot commented Sep 5, 2023 •

edited

Loading

michaelryanpeter commented Sep 29, 2023 •

edited

Loading