Repository navigation
Gate direct bench configuration changes with init checks - #3
Conversation
|
@codex review |
Reviewer's GuideIntroduces a pinned, repository-local CI check that validates process-reaping initialization in canonical, template, worker, and overlay Compose configurations for relevant PRs and main-branch changes. Sequence diagram for bench configuration validationsequenceDiagram
participant GitHub as GitHub Actions
participant Repo as Repository checkout
participant Checker as Pinned workBenches checker
participant Compose as Compose definitions
GitHub->>Repo: checkout()
GitHub->>Checker: checkout(repository, ref, path)
GitHub->>Checker: check-bench-init.py(.)
Checker->>Compose: read tracked docker-compose*.yml
Compose-->>Checker: configuration definitions
Checker-->>GitHub: validation result
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 613b796e84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add repository-local process-reaping validation for this setup-cloned bench.
Parent workBenches PRs cannot gate direct changes here because the setup clone is consumed from main, not a parent gitlink. This workflow checks the repository on every PR and main push without path filters, so a required check cannot remain pending because a workflow was skipped. Standard compose/docker-compose .yml/.yaml names and mixed-extension overlays are covered by the checker.
The checker is pinned to verified public workBenches commit 3f180c5c42cca2fce259105cb1252521423ee274, which the coordinated parent PR will preserve in main with a normal merge commit. No cross-repository secrets, image builds or container replacements are required. Both checkouts disable credential persistence.
Local effective-configuration checks and nine checker regression tests pass. This follows up the already merged process-reaping configuration fix and addresses the parent PR's final review finding.
Summary by Sourcery
Gate bench configuration changes with repository-local process-reaping validation.
Bug Fixes:
Enhancements:
CI: