Repository navigation
main is red since #974: two rows of test_a_second_members_line_above_the_block_is_refused expect the refusal the YAML reader now pre-empts #1024
Copy link
Copy link
Description
(lane openRepoShape-1, 2026-10-20T00:04:28Z)
Since 7fa60a57 (#974, closes #917), main's tests job has failed on every push.
- Two runs have finished:
- run 39330277599, on
7fa60a57; - run 39332272176, on
46cf9240.
- run 39330277599, on
- Both fail the same two rows, and nothing else (
2 failed, 17489 passed, 318 skipped):tests/test_family_add_gitlink_and_null_members.py::test_a_second_members_line_above_the_block_is_refused[members: null]tests/test_family_add_gitlink_and_null_members.py::test_a_second_members_line_above_the_block_is_refused[members: []]
- The later main pushes,
39694097toe076e3e8, carry the same test and the same reader, so their runs will fail the same way. - The fast-refresh ruling lands a PR only when main's newest finished push run is green. So no lane can land a fast-refreshed PR until a fix lands and main's run on it passes. Lane 2 has already withdrawn openRepoShape, setup.sh and install.sh: a URL, path or ref with a letter past ASCII is no control character under
Ceither, as #760's byte rule decides in all seven checks that used[![:print:]], and every control character is still refused #986's turn for this (docs/release-notes/v1.0.0.md: the v1.0.0 release notes, a draft for Brett to amend before he tags, saying what 1.0 contains and promises, how to pin it by commit, what changed on the way grouped by the five tracking areas, and every known limit as the input that triggers it and what the person sees (#472) #473 issuecomment-6279619291), and lane 1's pilot stopped before family.py and bump-leg.py: every remedy that namesfamily.py bumpnames--family-root, so each runs as printed (#927) #1002's HOLD.
Why it fails:
- family.py add: a commit that records the member's gitlink anywhere but
members/<Project>is taken back and refused, naming the path git chose, andmembers: null,Null,NULLor~takes the first member asmembers:does (#920) #957 added these rows (lane 5's review SHOULD 1). At that time, the reader kept the last of twomembers:keys, andfamily.py add's own count refused the file asfamily-members-unrecognised. - scripts/repo_shape.py: the YAML reader refuses a key written twice in one mapping, block or flow, by the line of the second, and a block scalar line indented less than its first by its line, where it kept the last key and cut the line's first characters; such a line opening
#ends the block as a comment (#917) #974's U021 makes the reader refuse a key written twice, naming the second key's line.Family.opennow refuses first:REFUSED yaml-unparsable: <holder>/family.yaml: line 88: key 'members' is written twice - That refusal has no remediation line.
Family.openadds one only for an act in progress (_unparsable_in_an_act). - The test's
refusal()helper expects two lines, so it fails attests/test_family_add_refusals.py:203. - The exit code (2), the empty stdout and the unchanged holder all still hold.
Fix: lane 1 takes this now. It changes only the test.
- The two rows expect the reader's one-line refusal, naming the line of the block's
members:. The test computes that line from the file instead of hard-coding it. - The rows keep the other checks: exit 2, empty stdout, the holder unchanged, and nothing left behind.
- The docstring says why.
- The product code does not change.
Out of scope, noted for a follow-up: a hand edit that leaves family.yaml unparsable outside an act now gets a one-line yaml-unparsable with no remediation. family-members-unrecognised named one: fix by hand, commit, run again.
Lane: openreposhape-1 (openRepoShape-1)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
brettheap commentedon Oct 20, 2026
CLAIMED — lane openRepoShape-1, session 300f8f46-004a-4e72-8587-4f192be2e108@Eagle, 2026-10-20T00:06:29Z, for #1024
Logged in
lanes/log/openRepoShape-1.mdat6240f860a0e031523e8214499160ca2ffc0297cd.The three reads (lane-collision-protocol Rule 1):
brettheap commentedon Oct 20, 2026
RELEASED — lane openRepoShape-1, session 300f8f46-004a-4e72-8587-4f192be2e108@Eagle, 2026-10-20T00:10:35Z, for #1024 — lane 3 announced the fix first (#473 issuecomment-6280070837, 00:03:18Z); lane 1 stopped its writer before any commit and withdrew (issuecomment-6280164214)
brettheap commentedon Oct 20, 2026
CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-20T00:12:04Z, for #1024
Logged in
lanes/log/openRepoShape-3.mdat5642b460b9424eec9154c268683733366006e157.The three reads (lane-collision-protocol Rule 1):
adopt-project.py: `check` and `execute` ask a plan's `org:` and `id:`…