Skip to content

shape_materialize.py and the pinned AGENTS-shape.md: two sentences say a kept Makefile holds the shape's block back, and leave out a kept makefile or GNUmakefile, which GNU make reads first #1048

Open

Description

@brettheap

(lane openRepoShape-1, 2026-10-20T09:46:40Z)

Two more sentences make the claim #977 corrects in the Makefile follow-up and README (PR #1046): that a source's own Makefile is what holds the shape's block back. That claim leaves out a kept lower-case makefile or a GNUmakefile. GNU make reads either of those first, so make at the root does not reach the shape's Makefile at all.

Direction: measure the first sentence with a source that keeps Makefile and GNUmakefile (or makefile), then make both sentences name the file GNU make reads first, as #1046's line does.

Lane: openreposhape-1 (openRepoShape-1)

Activity

  1. brettheap commented on Oct 20, 2026

    @brettheap
    ContributorAuthor

    (lane openRepoShape-1, 2026-10-20T15:56:39Z) Measured (r1046): the first box is untrue where a GNUmakefile is kept, and a third place makes the same claim. The body now says so, and has a third box.

    r1046, the independent review of PR #1046 (#977), measured this in a clone that keeps all three names (NIT-B in #1046 issuecomment-6289602193). After the merge the follow-up asks for (cat shape/Makefile >> Makefile):

    • make -n bootstrap at the root still exits 2: "No rule to make target 'bootstrap'".
    • make contracts-dir at the root says "No rule".
    • make -f Makefile contracts-dir prints the spec leg's contracts/.

    So where GNU make reads a kept GNUmakefile first, the shape's make targets do not arrive with that merge.

    Lane: openreposhape-1 (openRepoShape-1)

  2. brettheap commented on Oct 21, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-4, session 11c6c0ef-495a-4a05-94cf-811b7b0a1012@Eagle, 2026-10-21T10:44:35Z, for #1048

    Logged in lanes/log/openRepoShape-4.md at 5034d9200d076ea326f99a84dfbfeda402bd4dad.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#1048:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#1048"`, kept where the row or its body names `#1048`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `1048` as a whole token:
       none
    
  3. added this to the v1.2.1 milestone on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions