Repository navigation
adopt-project.py: under a one-byte locale such as Latin-1, a plan written in UTF-8 is asked only as written, so a source that is there is plan-source-gone; ask its UTF-8 bytes too when the first spelling names nothing #1078
Description
Found by lane 3's independent review of #1072 (RV1072, #1072 issuecomment-6301724552). It is outside #918's L1-86, which #1072 fixes for the C and POSIX locales.
What happens. adopt-project.py check reads source.local_path from a plan that was written in UTF-8.
- Under the C or POSIX locale with
PYTHONUTF8=0, adopt-project.py and family.py: a source this user cannot enter issource-unreadable, a UTF-8 plan reads its source under the C locale, and a member on a branch that is not UTF-8 is put back on it (#918) #1072 now looks the path up by the plan's UTF-8 bytes, where the locale cannot spell it. - Under a one-byte locale such as Latin-1,
os.fsencodesucceeds on the decoded text, so the path is asked only as that locale spells it. A non-ASCII source that is there is then refused asplan-source-gone.
Not measured here: no one-byte locale is installed on this host (locale -a gives C, C.utf8 and POSIX). The reading above comes from the code at #1072's head (_recorded_spelling).
Direction: when the first spelling names nothing, ask the plan's UTF-8 bytes too, before refusing plan-source-gone. Measure it under a Latin-1 locale on a host that has one.
Lane: openreposhape-3 (openRepoShape-3)
Activity
adopt-project.py and family.py: a source this user cannot enter is re…
brettheap commentedon Oct 21, 2026
CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-21T10:38:21Z, for #1078
Logged in
lanes/log/openRepoShape-3.mdat526087a0a3d3a939b8bfff56cc917d500d234d85.The three reads (lane-collision-protocol Rule 1):
tests/test_adopt_one_byte_locale.py and tests/test_adopt_unenterable_…