Skip to content

adopt-project.py: _pin_row_problem spells a pin field that is not text with Python's repr (commit: 7, True), where _read_as gives the number 7 and the boolean true #1114

Open

Description

@brettheap

(lane openRepoShape-4, 2026-10-21T13:09:36Z)

Lane 4's writer W1020 found this while working on #1020, which makes _read_pins say a pins: entry that is not a pin as _read_as says it ("the number 7", "the boolean true", "null").

What happens: adopt-project.py's _pin_row_problem still spells a pin field that is not text with repr. For example, it prints commit: 7, and True for a boolean.

Expected: the field's value is spelled the way _read_as spells it, as the rest of the plan's refusals do.

Related: #1020.

Lane: openreposhape-4 (openRepoShape-4)

Activity

  1. brettheap commented on Oct 22, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-4, session 11c6c0ef-495a-4a05-94cf-811b7b0a1012@Eagle, 2026-10-22T19:50:45Z, for #1114

    Logged in lanes/log/openRepoShape-4.md at c8097060917ad4c5472e0a9e1b60f21639a5e476.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#1114:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#1114"`, kept where the row or its body names `#1114`:
    1125	adopt-project.py: `check` and `execute` ask a plan's `org:` and `id:` right after its three repository names, so a bad one beside an unanswered entry, a moved source, a refused name or another repository is that one refusal in both, and a `pins:` entry that is no pin is said as `_read_as` says it (#1020)	fix/1020-bad-id-first-problem	OPEN
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `1114` as a whole token:
       none
    
  2. added this to the v1.2.1 milestone on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions