You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
family.py: follow-ups from RV1117's review of #1117 (#1005): the add that member-unknown names is refused on the tracking branch, the bare family.py, the <org> blank, and four older ones #1127
These are seven follow-ups from RV1117's independent review of PR #1117 (#1005) at 10dc011c (#1117 issuecomment-6318620190). None of them blocks #1117, which RV1117 found READY. N1 to N3 are about the three lines #1117 adds; N4 to N7 were there before it.
N1: on the holder's tracking branch, the add that bump's member-unknown names is refused. A fresh clone stands on the tracking branch, and there family.py add --family-root <holder> --member <org>/<P> is refused family-on-tracking-branch.
That refusal prints its own git switch -c line, so the chain still ends in a command that works. But the remedy reads as if it runs as printed.
The two remove lines can be reached there only from --dry-run.
Fix: say in member-unknown's remedy that the add runs off the tracking branch, or print the git switch -c line first.
Fix: print every remedy's command the way _add_command does, from one helper.
N3: <org> is left as a blank, although family.yaml's org: is known. Pasted unfilled, <org>/IRQS is a redirection in every shell, not a value. Where a file named org is in the working directory, it tries to create /IRQS, which an ordinary user is refused.
Fix: fill in the org from family.yaml where it is set, and leave the blank only where it is not.
CLAIMED — lane openRepoShape-5, session 50cede29-ab82-4ca3-9f67-d98e1a58c8d2@Eagle, 2026-10-22T20:02:41Z, for #1127
Logged in lanes/log/openRepoShape-5.md at 7fbfc8b93ae222a09fb362f8db098d1bca807b7b.
The three reads (lane-collision-protocol Rule 1):
1. existing `CLAIMED —` comments on opensoft/openRepoShape#1127:
none
2. `gh pr list --repo opensoft/openRepoShape --state all --search "#1127"`, kept where the row or its body names `#1127`:
1155 docs/release-notes/v1.2.0.md: the v1.2.0 release notes, a first draft for Brett Heap to amend before the tag docs/v1.2.0-release-notes MERGED
3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `1127` as a whole token:
none
Activity
brettheap commentedon Oct 22, 2026
CLAIMED — lane openRepoShape-5, session 50cede29-ab82-4ca3-9f67-d98e1a58c8d2@Eagle, 2026-10-22T20:02:41Z, for #1127
Logged in
lanes/log/openRepoShape-5.mdat7fbfc8b93ae222a09fb362f8db098d1bca807b7b.The three reads (lane-collision-protocol Rule 1):