Skip to content

tests/test_update_shape_landing.py: 8 of its 19 tests drive update-shape.py with a POSIX shell gh stub and are skipped on Windows, so the --pr landing and re-run paths (#204) are run by two of the three CI jobs #334

Closed
#336
Closed
tests/test_update_shape_landing.py: 8 of its 19 tests drive update-shape.py with a POSIX shell gh stub and are skipped on Windows, so the --pr landing and re-run paths (#204) are run by two of the three CI jobs#334
#336

Description

@brettheap
brettheap
opened on Oct 12, 2026

Lane: openreposhape-3 (openRepoShape-3)

What happens. Measured on be2790e: WINDOWS_SKIP decorates 8 tests of the 19 in the file. The file's own docstring says why: gh is a shell script on PATH, and CreateProcess reads no shebang. The tests that never reach gh, and the one that stubs it in-process, run on every platform.

Where. tests/test_update_shape_landing.py (GH_STUB, the eight @WINDOWS_SKIP tests, the first at :177); WINDOWS_SKIP in tests/conftest.py (:63).

Why it matters. #204's landing_failed, _finish_landing and the re-run promises are the code where Windows differs most (a missing gh, quoting, paths) and the tests-windows job does not run the tests that exercise it. Direction (from #227): more in-process tests, as the one that already stubs gh in-process does, so the third OS carries them.

Source. PR #227, ## Left out, third bullet.

Activity

  1. brettheap commented on Oct 12, 2026

    @brettheap
    brettheap
    on Oct 12, 2026
    ContributorAuthor

    CLAIMED — lane openRepoShape-3, session b2cc9e59-4dc8-4f43-b01b-81cb99c8b07e@Eagle, 2026-10-12T11:00:06Z, for #334

    Logged in lanes/log/openRepoShape-3.md at 53ae25b4605e71a9789f87b3589d88cdcb83a10d.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#334:
   none
2. `gh pr list --repo opensoft/openRepoShape --state all --search "#334"`, kept where the row or its body names `#334`:
   none
3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `334` as a whole token:
   none
  2. brettheap
    added a commit that references this issue on Oct 12, 2026

    tests/test_update_shape_landing.py: the `gh` its landing tests drive …

    8a14ac9
  3. brettheap
    closed this as completedin #336on Oct 12, 2026
  4. brettheap
    added 4 commits that reference this issue on Oct 12, 2026

    Merge origin/main (a1b3a4b: #299 via #315, #216 via #228, #260 via #316…

    a557f2a

    Merge origin/main 8cdca5e into fix/adopt-root-kept-symlinks: thirteen…

    cd4d8b3

    tests/test_update_shape_landing.py: the issue's re-run is still refus…

    3465a6a

    update-shape.py: a `--pr` re-run finishes the landing only when the w…

    87d2eb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions