Skip to content

adopt-project.py plan: with no --elected-by and no user.name, the refusal reads --elected-by is '', naming a flag that was never passed #529

Closed

Description

@brettheap

Only the unwritable-value path says the value was not given. This path should say so too.

From the v1.1.0 triage of the v1.0.0 known limits on #457. One pull request covers the lines below.

Lines

  • N6: no --elected-by and no user.name is refused --elected-by is '', naming a flag never passed. Where: adopt-project.py MANIFEST_FLAGS. Effort S; all. On main 3121945: MANIFEST_FLAGS maps ELECTED_BY to a bare --elected-by (adopt-project.py:2426); only the unwritable-value path says "not given". (source)

Each line above is marked → this issue on its tracking issue. Tick it there too when this closes.

The lines as written on the tracking issues

AT-adopt N6: plan with no --elected-by and no git config user.name is refused adopt-manifest-invalid: --elected-by is '', naming a flag the person never passed rather than the setting the empty default came from (probe on main 7a8b981; the label is adopt-project.py:1856, while the unwritable-value path at :1808 does say "not given, so git config user.name").
— #457, body

Activity

  1. added this to the v1.1.0 milestone on Oct 14, 2026
  2. brettheap commented on Oct 14, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-14T22:31:36Z, for #529

    Logged in lanes/log/openRepoShape-3.md at 8a4a06be6dc2e3b83734596a195ff02053d3ebe2.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#529:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#529"`, kept where the row or its body names `#529`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `529` as a whole token:
       none
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions