Skip to content

shape-doctor.py: no NEXT holds prose or a backtick (manifest kinds joins prose NEXTs with "; ", and zsh runs FAMILY_BESIDE_FIX's backticks) #548

Closed

Description

@brettheap

Fix manifest kinds, and add a guard test that no NEXT line holds a backtick or Remediation:. The guard also covers the run_checks path that #408 left with no known reach.

From the v1.1.0 triage of the v1.0.0 known limits on #460. One pull request covers the lines below.

Lines

  • manifest kinds still prints prose NEXTs joined by "; "; FAMILY_BESIDE_FIX's backticks run in interactive zsh. Where: shape-doctor.py check_manifest_kinds, FAMILY_BESIDE_FIX. Effort S; macOS (zsh). On main 3121945: Uncommon reach, with prose where a command belongs; command = "; ".join(fixes) (sd.py:2505) and the backticks (:2208-2212) are unchanged. (source)

Each line above is marked → this issue on its tracking issue. Tick it there too when this closes.

The lines as written on the tracking issues

check_manifest_kinds still prints prose NEXTs, joined by ; , for an unregistered kind no gate here runs, or a family.yaml beside an assembly root. FAMILY_BESIDE_FIX holds family.py init and family.py add in backticks, which an interactive zsh would run if the line were pasted. #277's fix excludes these by design: they are not commands.
— #460, comment

Activity

  1. added this to the v1.1.0 milestone on Oct 14, 2026
  2. brettheap commented on Oct 14, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-14T16:28:25Z, for #548

    Logged in lanes/log/openRepoShape-3.md at 083b09dc6418b65e8e3f8e78f99596c742112a19.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#548:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#548"`, kept where the row or its body names `#548`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `548` as a whole token:
       none
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions