Skip to content

tests/test_adopt_plan.py names one machine's scratchpad; the optional MedxEHR clone should come from an environment variable #61

Closed

Description

@brettheap

Lane: xfactory-2 (xFactory-2)

Follow-up found while implementing #59, filed on Brett Heap's word (2026-09-05, in session: "file the env var fix as a follow-up"); NOT claimed.

What

tests/test_adopt_plan.py:27 hard-codes a host-absolute path to an optional read-only clone of MedxSoft/MedxEHR:

MEDXEHR = Path("/tmp/claude-1000/-home-brett-projects-xFactory/"
               "12896b36-ff8f-40db-8814-0b19dc4296a7/scratchpad/"
               "adopt-inventory/MedxEHR")

The test that uses it copies the clone first and SKIPS when it is absent, so the suite is green everywhere — but the path names one machine's scratchpad from one session (6013a5b, 2026-09-02), which is exactly the kind of host-specific path the estate's Rule 1 (no host-absolute paths in committed files) forbids, and no other machine can ever opt in.

What lands

Read the location from an environment variable — SHAPE_MEDXEHR_CLONE (or a name matching the existing SHAPE_PIN_SOURCE_<PRODUCT> / SHAPE_UPSTREAM_PATH convention in this repository) — and skip with a message naming the variable when it is unset or the directory is missing. No default path. The comment above it keeps its reason ("a suite that only runs on the machine it was written on is not a suite") and gains the variable's name. One test-file change; no shipped code moves, no cap moves.

Lane: xfactory-2 (xFactory-2)

Activity

  1. brettheap commented on Sep 6, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane xfactory-2 (xFactory-2), second window (session harness 42466ae1-e3f5-42d1-b680-9bf896e6e8e8, cross-session name openreposhape-b1 [90c755]), 2026-09-06T02:22Z, on Brett Heap's word in session: "pick up #61 and merge on green too". Sibling search: no PR or branch touches tests/test_adopt_plan.py (gh pr list --state open: none open; git ls-remote --heads origin | grep -i adopt: none). Worktree ~/projects/openRepoShape-worktrees/medxehr-clone-env, branch fix/medxehr-clone-env from main 6942d83. Merge word: merge on green.

    Lane: xfactory-2 (xFactory-2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions