Skip to content

Pinned shape copies: AGENTS-shape.md's CONTRACTS_DIR sentence is false for every scaffolded root, and the chain WARNING offers remedies the scaffold lacks (one shape bump before the v1.1.0 tag) #610

Closed

Description

@brettheap

Shape-copy text, in one shape bump: the CONTRACTS_DIR sentence, the chain WARNING's remedies and raw --pin-source, validate-pins' note, and THE LOCKSTEP RULE's bump line.

From the checklist triage of 2026-10-15; Brett Heap approved its recommendations at 2026-10-15T16:49:38Z. One pull request covers the lines below.

Lands after: #570, #575 and #576.

Decision applied: the triage's D6: one shape bump before the v1.1.0 tag, so every project re-pins once for v1.1.0.

Lines

Rides along (backlog; tick it here if the same change covers it)

Each line above is marked → this issue on its tracking issue. Tick it there too when this closes.

The lines as written on the tracking issues

L2-33 (P3; templates/assembly-root/AGENTS-shape.md, #572 review): the pinned AGENTS-shape.md says the root Makefile exports $(CURDIR)/spec/contracts, which is untrue for a non-default adoption and for every scaffolded root.

— #459, comment

The scaffold's declared-unverified WARNING names remedies the scaffold lacks: "(a sibling checkout, SHAPE_PIN_SOURCE_, or --link-source = would let it be read)".

  • scaffold-project.py has no --link-source, and reads no sibling checkout: it calls link_pins_from_trees(chain, None, ...).
  • The text is _chain_link_findings' (scripts/repo_shape.py).
  • It neighbours L2-25 above, which is about setup's step (4).

— #459, comment

L2-30 (P3; scripts/repo_shape.py, #570 review): the scaffold's chain WARNING declared-unverified prints --pin-source raw, so an ESC in the path reaches stderr.

  • scripts/repo_shape.py:2693-2709 builds f"{path}: ..." in link_declarations, and scaffold-project.py:829 prints it, at 79dfd33.
  • Repro (review570-79dfd33/fix-list.md, U1): a clone at x<ESC>[31mRED whose project.yaml holds neutral_product_pins: 5 exits 0 with a raw ESC on stderr. This confirms w540's note.
  • Direction: spell the path as pin-source-unreadable does for a path that is not printable.

— #459, comment

L2-31 (P3; templates/assembly-root/scripts/validate-pins.py, #570 review): the root's validate-pins.py prints --pin-source as typed in its "not used" note, and an ESC reached the terminal.

— #459, comment

L2-39 (nit; templates/family-root/scripts/validate-family.py, #575 writer): the holder's THE LOCKSTEP RULE sentence names family.py bump --member <Project> --to <commit> with no --family-root and no branch step.

— #459, comment

Activity

  1. added this to the v1.1.0 milestone on Oct 15, 2026
  2. brettheap commented on Oct 15, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-2, session 81650e29-c906-4fe8-96c9-55580bfe0c44@Eagle, 2026-10-15T18:25:56Z, for #610

    Logged in lanes/log/openRepoShape-2.md at 0f4beb29762df57451633c064f7eaacebb1678c8.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#610:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#610"`, kept where the row or its body names `#610`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `610` as a whole token:
       none
    
  3. 1 remaining item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions