update-shape.py: the printed git show <target>:<source> lines are not shell-quoted, and the kept-copy check (#536, #604) reads if TYPE_CHECKING:, if False: and a raising try unlike Python, and asks only if an importer is a validator #675

Goal: the lines update-shape.py prints about a kept copy paste as printed, and its check of a kept copy's imports (#536, #604) answers as Python does where it claims to answer.

Filed by lane openRepoShape-5 on Brett Heap's word of 2026-10-16T12:17:02Z ("#458's update-shape/bump-leg (~22)"), from lines on #458: 6200820629 (R604's three lines on #616) and 6192496098 (its second line, second item: the untested try/else/finally import). Lane 4 judged the first three OPEN on main 95780dd (#473 comment 6215386495); lane 5 re-measured all four on main 879d804.

Lands after: nothing. update-shape.py is not a pinned copy, so no project re-pins. No open PR touches it.

Every line here is latent or exotic, and each says so itself: no shipped copy's path holds a blank or a quote, the validators import only repo_shape, and repo_shape.py imports no sibling copy. The issue is one small pull request if it is taken into v1.1.0 at all; leaving the four as known limits on #458 is a fair answer too.

Lines (path:line at main 879d804)

• The printed git show <target>:<source> commands are not shell-quoted. merge_by_hand (update-shape.py:3495-3525) builds f"git show {row.target}:{row.source}" (:3512) for update-conflict's remedy, and _missing_name_remediation (:3871-3912) builds `git show {target}:{kept[path].source}` (:3882) for update-accept-local-missing-name. A source path holding a blank makes git exit 128, and one holding a ' makes sh fail Unterminated quoted string. Latent: the source path is the standard's own (templates/assembly-root/...), and update-shape.py apply --accept-local: a kept .py copy that imports a name the run's new repo_shape.py dropped passes, and make bootstrap then dies on an ImportError #604 widened the second from module names to any kept .py path. The other printed paths are quoted by bump-leg.py and update-shape.py quote the paste lines that named a root or a path bare, the doctor's quote_arg quotes a leading = for zsh, and README says the printed commands are for a POSIX shell (#532) #588 (Printed commands are POSIX-only: quote the bare paste lines in bump-leg.py and update-shape.py, and say in the docs that pasted commands are for a POSIX shell #532). (Tracking: update-shape.py and bump-leg.py, keeping a project's shape copies and leg pins current #458's 6200820629, first line; read, not run.)
• The missing-name refusal's validators clause asks only whether an importer IS a validator. _missing_name_refusal (:3837-3856) sets validated = any(pair.importer in kind.validators for pair in pairs) (:3845) and says "the validators, which never import it, pass" otherwise. It does not ask whether a validator imports the importer, or the module. Shipped files cannot reach this today. (Tracking: update-shape.py and bump-leg.py, keeping a project's shape copies and leg pins current #458's 6200820629, second line; read.)
• The readers give two wrong answers in update-shape.py apply --accept-local: a kept .py copy that imports a name the run's new repo_shape.py dropped passes, and make bootstrap then dies on an ImportError #604's reverse direction. Measured with the module's own _names_defined_in and _names_imported on four sources:
  • A WRITTEN module whose only binding of NEW is under if TYPE_CHECKING:, in a try body that raises first (raise RuntimeError then NEW = 1), or under if False: reads NEW as defined (_bound_at, :4098-4123, enters every if and try body through _same_scope, :4126-4136), so the ImportError the refusal exists to stop gets through.
  • A KEPT copy with from repo_shape import NEW under if False: is refused, though Python starts it: _blocks_inside (:4009-4021) leaves out an if TYPE_CHECKING: body (_is_type_checking, :4050-4054) and no other constant-false test.
    (Tracking: update-shape.py and bump-leg.py, keeping a project's shape copies and leg pins current #458's 6200820629, third line.)
• No test holds an import in a try's else or finally. Measured: the code is right, _blocks_inside gives those clauses the outer answer and not the handler's, so try: pass / except ImportError: NEW = None / else: from repo_shape import NEW is read as taking NEW, and the same with finally:. tests/test_update_shape_kept_helper.py, the only file naming the refusal, has else: and finally: only as module-scope bindings (:596-625); mutant N5, reported by R560v, survives (not re-run). (Tracking: update-shape.py and bump-leg.py, keeping a project's shape copies and leg pins current #458's 6192496098, second line, second item; the first item, os.path.lexists, is in the issue for apply.)

Direction

• Quote: shlex.join(["git", "show", f"{target}:{source}"]) in both places. A plain path prints exactly as before, so the tests that hold today's text stay green, and a test with a blank and a quote in a source path (a fork's, built for the test) holds the new one.
• Clause: say it only where no importer is a validator AND no validator imports an importer or the module, with the same ast reading the check already has (_names_imported of each validator in kind.validators).
• Readers: do not enter an if TYPE_CHECKING: body or an if False:/if 0: body in _same_scope (a binding there is not a binding), and do not enter an if False: body in _blocks_inside; leave a statement after an unconditional raise in a try body out of _bound_at where that is a few lines, and say in the docstring that the rest stays "what this cannot tell, it does not refuse" (the module's own rule). Each reading gets its test.
• Test gap: add the else and finally sources above to the table of "what the check is answered by".

Overlaps: none with open PRs. The issue for apply also edits update-shape.py, at Rollback._restore (:2806), _land (:4372), push_branch (:4607), _is_block_header (:1378) and current_branch (:2223), regions apart from these.

Mark each line → this issue on #458, and tick it there when this closes.

🤖 Generated with Claude Code