You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
siblings.py and shape-doctor.py: a dangling Windows junction at ../<Project> still reads as an empty slot, because #784's dangling-link rule asks only is_symlink(), which is False for a junction; also ask os.path.isjunction, as family_link does #793
Goal: on Windows, make siblings and the doctor both name a dangling junction at ../<Project> as a dangling link, as #784 (PR #788) makes them name a dangling symlink.
Filed by lane openRepoShape-3 under v1.1.1, on Brett Heap's word of 2026-10-16T13:35:28Z ("yes create v1.1.1"). Lane 3's reviewer RV-d raised it as N2 on #788 (#788 (comment)).
Not measured: what the real clone does onto a dangling junction. Lane 3 has no Windows machine, and CI is Linux-only since ci: run the test suite on Linux only #597.
Precedent:
siblings.py:931 already asks getattr(os.path, "isjunction", lambda _: False) in family_link.
tests/test_family_siblings_placement.py:564-574 tests that on Linux by patching os.path.isjunction.
Keep the doctor and make siblings in agreement on the wording.
Tests: patch os.path.isjunction to say yes for the slot path, as test_family_siblings_placement.py does. Assert that the dry run, the real run's refusal and the doctor's row all word it as dangling.
CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-17T09:43:00Z, for #793
Logged in lanes/log/openRepoShape-3.md at 0d05968f9a10cc12c590d9c7551340fd0249c1bc.
The three reads (lane-collision-protocol Rule 1):
1. existing `CLAIMED —` comments on opensoft/openRepoShape#793:
none
2. `gh pr list --repo opensoft/openRepoShape --state all --search "#793"`, kept where the row or its body names `#793`:
none
3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `793` as a whole token:
none
Activity
brettheap commentedon Oct 17, 2026
CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-17T09:43:00Z, for #793
Logged in
lanes/log/openRepoShape-3.mdat0d05968f9a10cc12c590d9c7551340fd0249c1bc.The three reads (lane-collision-protocol Rule 1):
test_family_siblings_placement.py and test_shape_doctor.py: a Windows…
siblings.py and shape-doctor.py: a link to nothing at `../<Project>` …
siblings.py and shape-doctor.py: on Python 3.12 and later, a junction…
docs/release-notes/v1.1.1.md and release.yml: the v1.1.1 notes answer…
tests/test_path_guard_hygiene.py and shape-doctor.py: a bare is_file/…