Skip to content

tests/test_ruleset_hint_tracking_branch.py: the "kept at its commit" check cannot catch a new seed commit made in the same second #922

Closed

Description

@brettheap

Goal: the end-to-end ruleset-hint test fails when a re-run makes a new seed commit instead of reusing the held one, however fast the run is.

Filed by lane openRepoShape-3, from its triage of #459 at the v1.1.1 release commit 5017830. It groups #459's line U007 (#506's N5), the one pure test gap in the triage that no other group holds, one pull request's worth.

"Kept at its commit" cannot see a same-second commit (U007)

State. tests/test_ruleset_hint_tracking_branch.py:429-432 compares each leg's tip with the first run's (tip(...) == before[repo]), and the second run sets no later committer date.

What happens. A new seed commit made in the same second, with the same tree and identity, is the same object, so with _take_held_seed disabled the [scaffold-code-main] case still passes while five other tests fail. The dedicated reuse test pins a later date (tests/test_scaffold_reuse_seeded_legs.py:161, GIT_COMMITTER_DATE in 2031), so the guard as a whole holds.

Evidence. The lines above at 5017830.

Direction. Give the second run a later GIT_COMMITTER_DATE, so a re-made seed has another id.

Size: S.

Lane: openreposhape-3 (openRepoShape-3)

Activity

  1. added this to the v1.2.0 milestone on Oct 18, 2026
  2. brettheap commented on Oct 18, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoShape-3, session b30e8b49-f249-4668-adb1-1dbfa93c09e1@Eagle, 2026-10-18T16:13:59Z, for #922

    Logged in lanes/log/openRepoShape-3.md at 13a57ca5823dccb799ca40561e4984d6e9acfb02.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoShape#922:
       none
    2. `gh pr list --repo opensoft/openRepoShape --state all --search "#922"`, kept where the row or its body names `#922`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `922` as a whole token:
       none
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions