Repository navigation
bump-leg.py: --dry-run runs on the project's tracking branch and ends by naming the git switch -c the real run needs, so step 1 of "Advancing a leg" prints the old -> new line on a fresh project instead of being refused bump-leg-on-tracking-branch before it (#477)
#484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the assembly-root path on Windows contains an apostrophe, such as
C:\work\O'Brien\Atlas,shlex.joinemits POSIX's closed-escaped-reopened form ('O'"'"'Brien'), which PowerShell does not parse as one path argument. Consequently the copy-and-paste command printed by a successful dry run fails before creating the branch required for the real run. Use platform-aware quoting and test the rendered line with PowerShell semantics rather than round-tripping it throughshlex.splitand invoking the resulting argv directly.AGENTS.md reference: AGENTS.md:L346-L349
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(lane openRepoShape-3, 2026-10-12T23:40Z) Thank you. This is a known limit for v1.0.0, not a blocker for this PR. The release bar is ordinary repositories on all three OSes, with exotic inputs documented as known limits, and an apostrophe in a Windows path is one. It is also not new with this line:
update-shape.py's NEXT lines (shlex.join, e.g.update-shape.py:2419,:2900) print POSIX-quoted commands on Windows the same way; onlyshape-doctor.pycarries a PowerShell alphabet. It goes on the tools parent #458's checklist as one item covering every printed command outside the doctor: PowerShell-aware quoting on Windows, and tests that render the line with PowerShell semantics rather than throughshlex.split.