Skip to content

The prose still says "four" about inventories that hold six, ten and eleven — six sites, all predating #45 #58

Closed

Description

@brettheap

Copilot's round-5 review of #45 named six places where the prose still says four about inventories that have not held four for some time. Every one of them is already false on main at 8345d2f — INSTALLABLES has carried ELEVEN since Amendment 11 and SHIPPED_BASH SIX (openRepoTools, park, resume, status, restart→lane, lanes) — so this predates #45's diff, which renames one member of those lists and moves no count. Filed rather than folded into that pull request, whose diff is already fourteen files.

main at 8345d2f, verbatim:

tests/test_repo_hygiene.py:39   SHIPPED_BASH = ["openRepoTools", "park", "resume", "status", "restart", "lanes"]
openRepoTools:220               INSTALLABLES=(openRepoTools park resume status restart lanes lanes-edit.sh lane-start lane-end link-estates repos.tsv)

The sites, each of which contradicts a list in the same file or one it explains:

where what it says what is true
README.md:333 "Windows: all four files are bash" six PATH commands are bash, ten shipped bash files in the CI parse list
README.md:403 "The macOS job parses each of the four bash files with /bin/bash -n" the job's own list is ten
.github/workflows/tests.yml:177 "THE SAME SUITE ON macOS, because these four files are what a Mac runs" the step under it parses ten
openRepoTools:370 "ONE PATH NOTE for the four of them" ${#INSTALLABLES[@]}, which the line two above it prints
tests/test_repo_hygiene.py:6 "facts about the four bash files and the four documents" SHIPPED_BASH is six; the documents list is its own count
tests/test_repo_hygiene.py:2126 "every \n in these four bash files" the same six
tests/test_openrepotools_command.py:9-11 "There are FOUR files to answer for (openRepoTools, park, resume, status), because --install places all four or none" INSTALLED is eleven, and the module derives every other count from it
tests/test_openrepotools_command.py:530, 590, 632, 644 "the four of them", "all four or none", "the four files --install places", "which of the four were missing" the same eleven
tests/test_lane_helpers.sh:30, :312 "The four commands and the shipped alias table" six commands and the table

The rule this repository already applies is to DERIVE and not restate — tests/test_openrepotools_command.py derives every count it prints from INSTALLED, and #45's round-3 commit corrected exactly this class of drift in the paragraph above SHIPPED_BASH (tests/test_repo_hygiene.py:34). The fix here is the same one, applied to the six remaining sites: say "the shipped bash files" and "everything --install places" where the number is not load-bearing, and derive it where it is.

Worth a case of its own: a hygiene test that refuses a spelled count in the prose of a file that also defines the list it is about would stop this coming back a seventh time — but the six lines above are the act, and that test is a second decision.

Activity

  1. brettheap commented on Sep 14, 2026

    @brettheap
    ContributorAuthor

    CLAIMED — lane openRepoTools-3, session 4135b2c9-34a6-47e3-a156-5adebb632fae@Eagle, 2026-09-14T21:40:52Z, for #58

    Logged in lanes/log/openRepoTools-3.md at 08d058c7507d4c25a75d8dbd7e50a6ff8f591ac0.

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoTools#58:
       none
    2. `gh pr list --repo opensoft/openRepoTools --state all --search "#58"`, kept where the row or its body names `#58`:
       none
    3. `git ls-remote --heads git@github.com:opensoft/openRepoTools` branches naming `58` as a whole token:
       none
    
  2. brettheap commented on Sep 14, 2026

    @brettheap
    ContributorAuthor

    Two of the sites are already gone, fixed on main by #53 (66b4fb9, "two module comments now point at the lists instead of restating a stale file count"): tests/test_repo_hygiene.py's module docstring and tests/test_openrepotools_command.py's "There are FOUR files to answer for" paragraph. Measured on main at a954435 merged into feat/lane-the-word.

    What is left, same rule — say "the shipped bash files" / "everything --install places" where the number is not load-bearing, derive it where it is:

    file:line what it says
    README.md:352 "Windows: all four files are bash"
    README.md:422 "The macOS job parses each of the four bash files"
    .github/workflows/tests.yml:177 "because these four files are what a Mac runs"
    openRepoTools:408 "ONE PATH NOTE for the four of them"
    tests/test_repo_hygiene.py:2250 "every \n in these four bash files"
    tests/test_openrepotools_command.py:598, 658, 700, 712 "the four of them", "all four or none", "the four files --install places", "which of the four were missing"
    tests/test_lane_helpers.sh:30, :312 "The four commands and the shipped alias table"

    (Line numbers are feat/lane-the-word merged with a954435; they move with the file, the sentences do not.)

  3. brettheap commented on Oct 13, 2026

    @brettheap
    ContributorAuthor

    TAKEOVERopenRepoTools-3 — lane openRepoTools-5, session 0d83dca2-c18c-4bb0-99ce-896e6cafea02@Eagle, 2026-10-13T18:21:37Z, for #58

    Logged in lanes/log/openRepoTools-5.md at 72460f03074e229b7da2759f50e5b4af682ff4be (takeover of the stale claim held by lane openRepoTools-3).

    The three reads (lane-collision-protocol Rule 1):

    1. existing `CLAIMED —` comments on opensoft/openRepoTools#58:
    6:CLAIMED — lane openRepoTools-3, session 4135b2c9-34a6-47e3-a156-5adebb632fae@Eagle, 2026-09-14T21:40:52Z, for opensoft/openRepoTools#58
    13:1. existing `CLAIMED —` comments on opensoft/openRepoTools#58:
    2. `gh pr list --repo opensoft/openRepoTools --state all --search "#58"`, kept where the row or its body names `#58`:
    45	`lane`: one word lists the lanes and binds the one you pick — available goes through the launcher in its own directory and profile, LIVE HERE attaches and never starts a second process, bound elsewhere names where; and `restart` leaves the person's PATH in the same breath (Amendment 18 Addendum 1 and Addendum 2)	feat/lane-the-word	MERGED
    3. `git ls-remote --heads git@github.com:opensoft/openRepoTools` branches naming `58` as a whole token:
       none
    
  4. brettheap commented on Oct 13, 2026

    @brettheap
    ContributorAuthor

    RELEASED — lane openRepoTools-3, session 83619980-06bb-4469-ae73-2a8c5e61981a@Eagle, 2026-10-13T18:22:17Z, for #58 — Brett Heap 2026-10-11 gave #28-#89 to lane openRepoTools-5 (its RULED line of 16:19:19Z); lane 3 holds no live work on this number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions