lane-worktrees: close #170's --yes data-loss and gate holes, self-check every removal, switch --yes back on

lanes-edit.sh

@@ -1878,17 +1878,27 @@ node_modules/
 .venv/
 venv/
 site-packages/'
-bytecode_in_pathspec() {   # <repo> <pathspec>...
+bytecode_in_pathspec() {   # <repo> <pathspec>...   0 read (the paths printed) · 3 a read FAILED
   bip_repo="${1-}"; shift || :
   [ "$#" -gt 0 ] || return 0
   # WHAT THE ADD WOULD STAGE, AND WHAT IS STAGED ALREADY: `add --dry-run` says
   # nothing of a path the index already holds at these bytes, and the commit
   # takes it all the same. A staged DELETION of bytecode is a cleanup and is
   # let through (`--diff-filter=d`).
+  #
+  # A READ THAT FAILED IS NO "CLEAN" (#170 G13): a malformed magic pathspec, or
+  # an index git cannot read, made both reads exit 128 with their stderr thrown
+  # away and printed nothing, and the check passed. Each status is kept now.
+  # `add --dry-run`'s 1 is the one answer that is not a failure: it means some
+  # NAMED path is ignored, which the add would not stage.
+  bip_add=""; bip_rc=0
+  bip_add="$(git -C "$bip_repo" add --dry-run --ignore-missing -- "$@" 2>/dev/null)" || bip_rc=$?
+  [ "$bip_rc" -le 1 ] || return 3
+  bip_staged=""
+  bip_staged="$(git -C "$bip_repo" diff --cached --name-only --diff-filter=d -- "$@" 2>/dev/null)" || return 3
   {
-    git -C "$bip_repo" add --dry-run --ignore-missing -- "$@" 2>/dev/null |
-      sed -n "s/^add '\(.*\)'\$/\1/p"
-    git -C "$bip_repo" diff --cached --name-only --diff-filter=d -- "$@" 2>/dev/null
+    printf '%s\n' "$bip_add" | sed -n "s/^add '\(.*\)'\$/\1/p"
+    printf '%s\n' "$bip_staged"
   } |
     awk '!seen[$0]++ {
       n = split($0, part, "/"); hit = 0
@@ -1991,7 +2001,9 @@ commit_push() {
       || die "git update-index --force-remove $cp_ren failed — the log is already renamed on disk and git still holds the old path, so nothing was committed. Re-run; if it refuses again, \`git -C $LANES_REPO rm --cached -- $cp_ren\` is the same act by hand." 6
   fi
   if [ "$cp_add_n" -gt 0 ]; then
-    cp_byte="$(bytecode_in_pathspec "$LANES_REPO" ${cp_add[@]+"${cp_add[@]}"})"
+    cp_brc=0
+    cp_byte="$(bytecode_in_pathspec "$LANES_REPO" ${cp_add[@]+"${cp_add[@]}"})" || cp_brc=$?
+    [ "$cp_brc" = 0 ] || die "git could not read what this commit would stage (a pathspec it cannot parse, or an index it cannot read), so whether it carries bytecode is unknown; nothing was staged or committed (opensoft/openRepoTools#170 G13)" 2
     [ -z "$cp_byte" ] || die "$(bytecode_refusal_text "$cp_byte")" 2
     git -C "$LANES_REPO" -c "$CP_EXACT" add -- ${cp_add[@]+"${cp_add[@]}"} || die "git add failed" 6
   fi
@@ -16998,11 +17010,17 @@ EOF
   # refuses such a pathspec for every write this file makes; attachments are
   # committed by hand, so this is the same question for a person to ask first.
   #   0  nothing in those paths would stage bytecode, a cache or an environment
-  #   2  something would: the paths on stdout, the offer on stderr
+  #   2  something would: the paths on stdout, the offer on stderr - or git
+  #      could not read what they would stage, which is never "clean" (#170 G13)
   #  64  usage
   pathspec-check)
     [ "$#" -gt 0 ] || die "usage: pathspec-check <path>...   (relative to the workspace repository $LANES_REPO)" 64
-    pck_out="$(bytecode_in_pathspec "$LANES_REPO" "$@")"
+    pck_rc=0
+    pck_out="$(bytecode_in_pathspec "$LANES_REPO" "$@")" || pck_rc=$?
+    if [ "$pck_rc" != 0 ]; then
+      note "git could not read what that pathspec would stage (a pathspec it cannot parse, or an index it cannot read), so whether it holds bytecode is unknown, and an unknown is never reported clean (opensoft/openRepoTools#170 G13)"
+      exit 2
+    fi
     if [ -n "$pck_out" ]; then
       printf '%s\n' "$pck_out"
       note "$(bytecode_refusal_text "$pck_out")"

tests/run.sh

@@ -154,6 +154,10 @@ make_run_root() {
     exit 1
   }
   chmod 700 "$RUN_ROOT" 2>/dev/null || :
+  # THE RUN'S MARK: `lane-worktrees sweep --include-sandboxes` removes a
+  # temporary directory only on proof a suite made it (#170 item 1), and this
+  # pid is that proof for a run root a SIGKILL left behind.
+  printf '%s\n' "$$" > "$RUN_ROOT/.openrepotools-run" 2>/dev/null || :
   export TMPDIR="$RUN_ROOT/tmp"
   export PYTHONPYCACHEPREFIX="${XDG_CACHE_HOME:-$HOME/.cache}/openRepoTools/pycache"
   venv="${XDG_CACHE_HOME:-$HOME/.cache}/openRepoTools/venvs/openRepoTools"

tests/test_lane_helpers.sh

@@ -15600,6 +15600,16 @@ has  "…a venv under any name included, by its site-packages" "$out" "$B162_REL
 has  "…and the line that covers it is among those offered" "$err" "'site-packages/'"
 run "$E" pathspec-check "$B162_REL/r1/notes.md"
 is   "a pathspec with nothing of the kind passes" "$rc" 0
+# A READ THAT FAILED IS NO "CLEAN" (#170 G13): a malformed magic pathspec makes
+# both git reads exit 128, and the check printed nothing and passed.
+run "$E" pathspec-check ':(bogus)x'
+is   "a pathspec git cannot read is refused, never reported clean" "$rc" 2
+has  "…saying the read failed" "$err" "could not read what that pathspec would stage"
+b162_head="$(git -C "$WIP" rev-parse HEAD)"
+run env LANES_LANE=repoA-1 LANES_PATH=':(bogus)x' "$E" commit "attach nothing"
+is   "…and the commit path refuses it before the add" "$rc" 2
+has  "…saying so" "$err" "could not read what this commit would stage"
+is   "…committing nothing" "$(git -C "$WIP" rev-parse HEAD)" "$b162_head"
 b162_head="$(git -C "$WIP" rev-parse HEAD)"
 run env LANES_LANE=repoA-1 LANES_PATH="$B162_REL" "$E" commit "attach r1"
 is   "the commit path refuses the same pathspec" "$rc" 2