Repository navigation
Add HeatingCircuit.get{Program,Reduced,Comfort,Normal,ActiveProgram}Temperature() - #853
Open
PhrozenByte wants to merge 1 commit into
Open
PhrozenByte wants to merge 1 commit into
PhrozenByte wants to merge 1 commit into
Conversation
PhrozenByte
force-pushed
the
bugfix/heating-modes-temps
branch
from
October 16, 2026 16:25
e39d761 to
60c78d1
Compare
Author
|
Since there don't seem to be any unit tests for |
PhrozenByte
force-pushed
the
bugfix/heating-modes-temps
branch
from
October 16, 2026 17:06
60c78d1 to
cab90f8
Compare
…Temperature()`
`get{Reduced,Comfort,Normal}Temperature()` are shortcut methods for accessing the basic target room temperatures, complementing the existing `set{Reduced,Comfort,Normal}Temperature()` methods.
`getProgramTemperature()` replaces the now-deprecated `getDesiredTemperatureForProgram()`.
`getActiveProgramTemperature()` replaces the now-deprecated `getCurrentDesiredTemperature()` and additionally supports holiday mode (openviess#851). Other complex programs are not yet implemented and may still raise either `PyViCareNotSupportedFeatureError` or `KeyError`.
All temperature getters and setters now also support the program names used by reversible heat pumps (e.g., `"reducedHeating"` instead of `"reduced"`).
Fixes openviess#851
PhrozenByte
force-pushed
the
bugfix/heating-modes-temps
branch
from
October 16, 2026 17:07
cab90f8 to
6844932
Compare
PhrozenByte
changed the title
PyViCareHeatingDevice.get{Program,Reduced,Comfort,Normal,ActiveProgram}Temperature()HeatingCircuit.get{Program,Reduced,Comfort,Normal,ActiveProgram}Temperature()
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get{Reduced,Comfort,Normal}Temperature()are shortcut methods for accessing the basic target room temperatures, complementing the existingset{Reduced,Comfort,Normal}Temperature()methods.getProgramTemperature()replaces the now-deprecatedgetDesiredTemperatureForProgram().getActiveProgramTemperature()replaces the now-deprecatedgetCurrentDesiredTemperature()and additionally supports holiday mode (#851). Other complex programs are not yet implemented and may still raise eitherPyViCareNotSupportedFeatureErrororKeyError.All temperature getters and setters now also support the program names used by reversible heat pumps (e.g.,
"reducedHeating"instead of"reduced").Fixes #851