Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The task-detection flag is unused, so tests supplying explicit tasks still bypass automatic detection.
1 open finding
What changed in this PR
Adds functional-test configuration for automatic task and pooling detection in OVMS.
Changes:
- Adds default-enabled task and pooling detection flags.
- Omits explicit pooling in Docker and binary launchers when detection is enabled.
- Adds an embeddings pooling log-message constant.
| File | Description |
|---|---|
| tests/functional/object_model/ovms_docker.py | Applies pooling detection to Docker launches. |
| tests/functional/object_model/ovms_binary.py | Applies pooling detection to binary launches. |
| tests/functional/constants/ovms_messages.py | Adds a pooling log-message template. |
| tests/functional/config.py | Defines task and pooling detection flags. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| huggingface_token = os.environ.get("TT_HUGGINGFACE_TOKEN") or get_token_value(huggingface_token_file_path, "") | ||
|
|
||
| """ TT_ENABLE_TASK_DETECTION - during model pull/export use task automatically detected by OVMS """ | ||
| enable_task_detection = get_bool("TT_ENABLE_TASK_DETECTION", True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Add automatic task/pooling detection to testing
🧪 Checklist
``