Skip to content

Fix 64-bit integer parsing in KServe REST inputs - #4689

Open
YugShah1510 wants to merge 1 commit into
openvinotoolkit:mainfrom
YugShah1510:fix/kfs-rest-64bit-inputs
Open

YugShah1510 wants to merge 1 commit into
openvinotoolkit:mainfrom
YugShah1510:fix/kfs-rest-64bit-inputs

Conversation

@YugShah1510

Copy link
Copy Markdown

Summary

  • Validate INT64 inputs with RapidJSON IsInt64() and UINT64 inputs with IsUint64() before reading their 64-bit values.
  • Add regression coverage for values above the 32-bit signed and unsigned ranges.

Fixes #4688

Validation

  • git diff --check — passed.
  • The targeted OVMS C++ parser tests were not run: Bazel/Bazelisk and a built ovms_test binary are unavailable in this environment.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow validation changes correctly match the existing getters, and regression tests cover both reported failures with no blocking issues identified.

No open issues 🎉

What changed in this PR

Fixes #4688 by allowing KServe REST inputs to accept 64-bit integers beyond the corresponding 32-bit ranges.

Changes:

  • Uses IsInt64() and IsUint64() to match the existing 64-bit getters.
  • Adds regression tests that verify acceptance and value preservation for both reported failures.

The targeted C++ tests were not run because the required build tools and test binary were unavailable.

File Description
src/​test/​kfs_rest_parser_test.cpp Adds signed and unsigned regression cases above the 32-bit limits.
src/​rest_parser.cpp Corrects validation checks for INT64 and UINT64 inputs.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KServe REST rejects INT64 and UINT64 values outside 32-bit range

2 participants