Repository navigation
Fix 64-bit integer parsing in KServe REST inputs - #4689
Open
YugShah1510 wants to merge 1 commit into
Open
YugShah1510 wants to merge 1 commit into
YugShah1510 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow validation changes correctly match the existing getters, and regression tests cover both reported failures with no blocking issues identified.
No open issues 🎉
What changed in this PR
Fixes #4688 by allowing KServe REST inputs to accept 64-bit integers beyond the corresponding 32-bit ranges.
Changes:
- Uses
IsInt64()andIsUint64()to match the existing 64-bit getters. - Adds regression tests that verify acceptance and value preservation for both reported failures.
The targeted C++ tests were not run because the required build tools and test binary were unavailable.
| File | Description |
|---|---|
src/test/kfs_rest_parser_test.cpp |
Adds signed and unsigned regression cases above the 32-bit limits. |
src/rest_parser.cpp |
Corrects validation checks for INT64 and UINT64 inputs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INT64inputs with RapidJSONIsInt64()andUINT64inputs withIsUint64()before reading their 64-bit values.Fixes #4688
Validation
git diff --check— passed.ovms_testbinary are unavailable in this environment.