Skip to content

In some case response wasn't log before throwing exception - #822

Merged
jonesbusy merged 1 commit into
oras-project:mainfrom
jonesbusy:feature/log-response-error
Jul 29, 2026
Merged

In some case response wasn't log before throwing exception#822
jonesbusy merged 1 commit into
oras-project:mainfrom
jonesbusy:feature/log-response-error

Conversation

@jonesbusy

Copy link
Copy Markdown
Collaborator

Description

In some case response wasn't log before throwing exception

Testing done

Checked logs

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.37%. Comparing base (21eaa01) to head (eb2ef54).

Files with missing lines Patch % Lines
src/main/java/land/oras/auth/HttpClient.java 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #822      +/-   ##
============================================
+ Coverage     86.94%   87.37%   +0.42%     
- Complexity     1259     1261       +2     
============================================
  Files            50       50              
  Lines          4060     4070      +10     
  Branches        556      558       +2     
============================================
+ Hits           3530     3556      +26     
+ Misses          314      296      -18     
- Partials        216      218       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@jonesbusy
jonesbusy force-pushed the feature/log-response-error branch 2 times, most recently from d3bdfe4 to b9f7d61 Compare July 29, 2026 09:01
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy
jonesbusy force-pushed the feature/log-response-error branch from b9f7d61 to eb2ef54 Compare July 29, 2026 09:01
@jonesbusy
jonesbusy merged commit b655d98 into oras-project:main Jul 29, 2026
9 checks passed
@jonesbusy
jonesbusy deleted the feature/log-response-error branch July 29, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant