Skip to content

Key TokenCache entries by auth provider identity, not just scope - #826

Merged
jonesbusy merged 1 commit into
oras-project:mainfrom
jonesbusy:fix/token-cache-identity-collision
Jul 29, 2026
Merged

Key TokenCache entries by auth provider identity, not just scope#826
jonesbusy merged 1 commit into
oras-project:mainfrom
jonesbusy:fix/token-cache-identity-collision

Conversation

@jonesbusy

Copy link
Copy Markdown
Collaborator

Description

Key TokenCache entries by auth provider identity, not just scope

Testing done

Let CI do it

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy added the bug Something isn't working label Jul 29, 2026
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy
jonesbusy force-pushed the fix/token-cache-identity-collision branch from 57160b1 to 13d5d0d Compare July 29, 2026 09:39
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.48%. Comparing base (b655d98) to head (13d5d0d).

Files with missing lines Patch % Lines
.../main/java/land/oras/auth/BearerTokenProvider.java 80.00% 2 Missing ⚠️
src/main/java/land/oras/auth/Scopes.java 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #826      +/-   ##
============================================
+ Coverage     86.95%   87.48%   +0.53%     
- Complexity     1261     1274      +13     
============================================
  Files            50       51       +1     
  Lines          4070     4091      +21     
  Branches        558      561       +3     
============================================
+ Hits           3539     3579      +40     
+ Misses          313      295      -18     
+ Partials        218      217       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@jonesbusy
jonesbusy merged commit f517074 into oras-project:main Jul 29, 2026
9 checks passed
@jonesbusy
jonesbusy deleted the fix/token-cache-identity-collision branch July 29, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant