Skip to content

ci(otter): web browser tests restart Chromium between shards #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Laurin-Notemann merged 1 commit into from
Nov 11, 2026
Merged

ci(otter): web browser tests restart Chromium between shards #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/scripts/otter-adapt-upstream.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ perl -pi -e 's/^( timeout-minutes: )10$/${1}20/' .github/workflows/release.ym
# web test job needs more time than upstream's 8-vCPU runners do.
perl -0pi -e 's/(\n test_web:\n(?: .*\n)*? timeout-minutes: )10\n/${1}20\n/' .github/workflows/ci.yml

# A single browser session over every web browser test runs Chromium out of memory on
# the 16 GB GitHub-hosted runners, closing the page at a different file each run. Separate
# processes and two browser shards give each a fresh Chromium.
perl -pi -e 's|^(\s+)run: vp run --filter \@t3tools/web test$|$1run: \|\n$1 cd apps/web\n$1 vp test run --passWithNoTests --project unit\n$1 vp test run --passWithNoTests --project browser --shard 1/2\n$1 vp test run --passWithNoTests --project browser --shard 2/2|' \
.github/workflows/ci.yml .github/workflows/release.yml

# The production relay deploy must run for this repository after an upstream sync.
python3 - <<'PY_RELAY'
from pathlib import Path
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,11 @@ jobs:
fi

- name: Test
run: vp run --filter @t3tools/web test
run: |
cd apps/web
vp test run --passWithNoTests --project unit
vp test run --passWithNoTests --project browser --shard 1/2
vp test run --passWithNoTests --project browser --shard 2/2

# apps/server sets `fileParallelism: false`, so its test files run strictly
# one at a time. Sharding spreads them over separate runners instead of
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,11 @@ jobs:
fi

- name: Test
run: vp run --filter @t3tools/web test
run: |
cd apps/web
vp test run --passWithNoTests --project unit
vp test run --passWithNoTests --project browser --shard 1/2
vp test run --passWithNoTests --project browser --shard 2/2

# Browser tests run source modules; this boots the production chunk graph.
- name: Boot the built web client
Expand Down
Loading