Conversation
fix(ajax): send no-cache headers on JSON responses Add Cache-Control and Pragma no-cache headers in dieJson() so Packlink AJAX responses are never cached. The draft-status endpoint (OrderDraft::getDraftStatus) returns JSON with only a Content-Type header. Without cache-control headers, a GET response can be served stale by the browser or an intermediate cache. As a result the order panel kept showing "Draft is currently being created" even after the shipment draft had actually been created on Packlink's side. Forcing no-store/no-cache on all dieJson() responses makes the status poll always reflect the real state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ajax): send no-cache headers on JSON responses
Add Cache-Control and Pragma no-cache headers in dieJson() so Packlink AJAX responses are never cached.
The draft-status endpoint (OrderDraft::getDraftStatus) returns JSON with only a Content-Type header. Without cache-control headers, a GET response can be served stale by the browser or an intermediate cache. As a result the order panel kept showing "Draft is currently being created" even after the shipment draft had actually been created on Packlink's side.
Forcing no-store/no-cache on all dieJson() responses makes the status poll always reflect the real state.