fix(web): filter the archive by the shared settings scope - #198
Merged
Merged
Conversation
Picking a project on Settings > Archive showed "This project is no longer available." The archive stored its filter in the same `?project=` search key the settings layout now reads as the shared scope, but wrote a `<environmentId>:<projectId>` value where the layout expects a logical group key. The lookup failed and the layout replaced the page with the unavailable-scope message. The archive now reads the shared scope instead of keeping its own filter. The project axis narrows by logical group, so every checkout of a grouped project stays together, and the environment and checkout axes narrow the threads inside a group. The page's own project dropdown is gone; the breadcrumb selects cover it. Deep links from the command palette, the project settings page, and the legacy sidebar pass the group key.
Review follow-ups. A project scope now also matches an archive group that keys one of the project's live checkouts under a different logical key, which happens when the archive snapshot carries a fresher repository identity than the live project. A scope pinned to one environment only fetches that environment's archive, so another machine's outage or slow load no longer marks the view failed or pending. The global "open archived threads" actions clear the scope explicitly, since the settings layout keeps the previous selection when a navigation names no keys.
pandec
marked this pull request as ready for review
September 14, 2026 05:50
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughArchived-thread filtering now follows the settings scope. The project picker and route-level project filter were removed. Navigation resolves logical project groups or preserves the current scope. ChangesArchived thread scope
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~30 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant SettingsScope
participant ArchivedThreadsPanel
participant ArchivedSnapshotQuery
participant ScopeMatchers
SettingsScope->>ArchivedThreadsPanel: provide resolved settings scope
ArchivedThreadsPanel->>ArchivedSnapshotQuery: query scoped environment IDs
ArchivedThreadsPanel->>ScopeMatchers: match archived groups and threads
ScopeMatchers-->>ArchivedThreadsPanel: matching archived items
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Archive navigation and filtering preserve the intended settings scope without exposing unrelated threads. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 10 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking a project on Settings > Archive always showed "This project is no longer available." The archive kept its own filter in the
?project=search key, as<environmentId>:<projectId>. Upstream's shared settings scope (pingdotgg#10636) now reads that same key as a logical group key, so every pick resolved to a missing project and the layout hid the page.The archive now reads the shared settings scope instead of owning a filter. The project axis narrows by logical group, so a grouped project keeps every checkout's threads together, and the environment and checkout axes narrow the threads inside a group. The page's own project dropdown is gone since the breadcrumb selects already cover it. Deep links from the command palette, project settings, and the legacy sidebar pass the group key.
Fork-only change, so no screenshots.
Model: Claude Fable 5.1 through T3 Code with the Claude Code harness.
Summary by CodeRabbit
New Features
UI Changes