Skip to content

[4.0] HTML attribute line dedenting after typing "end" #160

Open

Description

@davidwarrington

For reference I'm using the latest VSIX on the next branch

This is a weird one. I was just editing an inline attribute that contains liquid and found that if I type anything after "end" inside the closing Liquid tag it dedents the line.

Screen.Recording.2023-07-20.at.15.19.07.mov

This isn't a critical issue - I can reindent it.

Activity

  1. panoply commented on Jul 21, 2023

    @panoply
    Owner

    Interesting one. Definitely a bug, probably because in Æsthetic it is looking for {% endif %} but it shouldn't, so we have a defect here. I'll upstream to Æsthetic. Might be something I introduced with markup rules lineBreakValue and delimiterTerminus which I still haven't bumped in latest version.

    In any sense (as always) this was a good catch.

  2. added
    BugSomething isn't working in the vscode extension
    🎀 ÆstheticThe issue pertains to Æsthetic
    on Jul 21, 2023
  3. changed the title [-]HTML attribute line dedenting after typing "end"[/-] [+][4.0] HTML attribute line dedenting after typing "end"[/+] on Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working in the vscode extension🎀 ÆstheticThe issue pertains to Æsthetic

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions