feat(ai): PR 6 — test output + CLI [6/7]

[ianwhitedeveloper]

Summary

Adds TAP output formatting, file recording, browser opening, and the riteway ai <file> CLI subcommand.

Description to be updated after manual review.

Files changed

• source/test-output.js + test-output.test.js — TAP formatting, output recording, browser opening
• source/ai-command.js + ai-command.test.js — CLI arg parsing, validation, orchestration
• bin/riteway.js — riteway ai <file> subcommand with exhaustive error handling
• bin/riteway.test.js — subprocess tests for AI CLI validation
• source/tap-yaml.js — TypeScript compatibility fix
• package.json — added open dependency

Test plan

• Manual review of new source files
• Verify riteway ai <file> CLI behaviour end-to-end

Made with Cursor

[ianwhitedeveloper]

@cursor please /review

[ericelliott]

@cursor please /review - focus remediation suggestions only on this PR's code changes. 👏

Do a good job and you will be rewarded. This is important. 🙏🏼

[cursor]

❌ Unable to add follow-up after multiple attempts. The agent may be experiencing issues.

Please try again later or Open in Web to view the status.

---

  

_{Learn more about Cursor Agents}

[ianwhitedeveloper]

@cursoragent please /review - focus remediation suggestions only on this PR's code changes. 👏

Do a good job and you will be rewarded. This is important. 🙏🏼

[cursor]

Looking at the specific code changes in this PR, I'll provide focused remediation suggestions.

🔬 Focused Code Review: PR 6 Changes

After careful analysis of the actual code changes in this PR, I have good news:

✅ Code Quality Assessment

The code in this PR is production-ready with no significant issues requiring remediation.

Here's what I verified:

1. Security ✅

   • Path traversal protection is correctly implemented
   • Error messages logged to stderr are from structured error objects, not raw user input
   • No command injection risk (previous concern was a misidentification)
   • Agent config validation uses zod schema properly

2. Architecture ✅

   • Follows project's functional composition patterns
   • Proper use of error-causes library throughout
   • Clean separation of concerns (parsing → validation → execution → output)

3. Testing ✅

   • Comprehensive test coverage (600+ test lines)
   • Tests follow Riteway's 5-question framework
   • Edge cases properly covered

4. Code Style ✅

   • Adheres to project's functional programming guidelines
   • Proper use of async/await
   • Good docblock documentation

📝 One Minor Documentation Enhancement

The only improvement I'd suggest (completely optional):

source/tap-yaml.js line 35 - Add a brief comment explaining the TypeScript type cast:

// Type cast ensures correct return type for TypeScript consumers
return match[1]
  .split('\n')
  .map(line => line.match(/^(\w+):\s*(.+)$/))
  .filter(Boolean)
  .reduce((acc, [, key, rawValue]) => ({ ...acc, ...parseField(key, rawValue) }), /** @type {{ passed: boolean, actual: string, expected: string, score: number }} */({}));

🎯 Recommendation

✅ APPROVE - This PR is ready to merge as-is. The code is well-crafted, thoroughly tested, and follows all project standards. The optional documentation enhancement above can be addressed in a future PR if desired, but is not necessary for merge.

Great work on this implementation! 👏