Skip to content

fix: Bump ws from 8.20.0 to 8.21.0 - #3068

Merged
mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/ws-8.21.0
Jul 13, 2026
Merged

mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/ws-8.21.0

Conversation

@mtrezza

@mtrezza mtrezza commented Jul 13, 2026 •

Copy link
Copy Markdown
Member

Bumps ws from 8.20.0 to 8.21.0. ws is a direct production dependency.

This replaces the Dependabot PR #3049 so the change lands with a fix: prefix, reflecting that it resolves security advisories in a production dependency.

Closes #3049

Security

Resolves the following advisories in ws:

Changes

Breaking Changes

None

Code Changes Required

None — the upgrade is a drop-in replacement.

Summary by CodeRabbit

  • Chores
    • Updated the WebSocket dependency to version 8.21.0.
    • Refreshed dependency lock information to keep installations consistent.

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@mtrezza

mtrezza commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates the direct ws dependency from 8.20.0 to 8.21.0 and synchronizes corresponding root and nested package-lock.json entries, including resolved artifacts, integrity hashes, and lock metadata.

Changes

ws dependency update

Layer / File(s) Summary
Update ws dependency declaration
package.json
Changes the declared ws dependency from 8.20.0 to 8.21.0.
Synchronize ws lockfile entries
package-lock.json
Updates root and nested ws versions, resolved URLs, integrity hashes, and related lock metadata. One entry retains 8.20.0 while adding dev: true and an empty requires object.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: dependabot[bot], semantic-release-bot, coratgerl, dblythy, dplewis


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Engage In Review Feedback ❌ Error The reviewer asked to bump transitive ws pins, but package-lock.json still contains ws@8.20.0 under parse-server/parse. Update the remaining transitive ws pins (or add a justified override) and reply to the reviewer before resolving the feedback.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the dependency bump and uses an allowed prefix with proper capitalization.
Description check ✅ Passed The description covers the upgrade, issue closure, security impact, and no-breaking-change notes, which is sufficient despite non-template headings.
Linked Issues check ✅ Passed The ws upgrade to 8.21.0 satisfies the directly linked issue's required version bump and security fix.
Out of Scope Changes check ✅ Passed Only ws dependency and lockfile entries changed, so no unrelated scope was introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed Only manifest/lockfile updates; production ws is bumped to 8.21.0 and the remaining 8.20.0 pins are dev-only under parse-server.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously requested changes Jul 13, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package-lock.json`:
- Around line 29403-29424: Update the dependency resolution so all transitive ws
entries use 8.21.0 instead of 8.20.0, adding a package.json override or
upgrading the upstream dependencies as appropriate. Apply this to
package-lock.json lines 29403-29424 and 56322-56328, ensuring both parse-server
and parse resolve the non-vulnerable ws release.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 74267031-85d9-487f-b4e6-edd330adb4a0

📥 Commits

Reviewing files that changed from the base of the PR and between 96ec749 and ca5ebde.

📒 Files selected for processing (2)
  • package-lock.json
  • package.json

Comment thread package-lock.json
@mtrezza
mtrezza dismissed coderabbitai[bot]’s stale review July 13, 2026 23:01

Dismissing: the requested override targets the dev-only transitive ws pin under parse-server (a devDependency used only for tests). The production ws dependency is fully upgraded to 8.21.0 and this PR matches Dependabot's own resolution; production is fully patched. The residual dev-tree pin clears once parse-server ships ws 8.21.0. Out of scope for this security fix.

@mtrezza
mtrezza merged commit 1b0fd5d into parse-community:alpha Jul 13, 2026
11 checks passed
@mtrezza
mtrezza deleted the fix/ws-8.21.0 branch July 13, 2026 23:01
parseplatformorg pushed a commit that referenced this pull request Jul 13, 2026
## [8.6.1-alpha.1](8.6.0...8.6.1-alpha.1) (2026-07-13)

### Bug Fixes

* Bump ws from 8.20.0 to 8.21.0 ([#3068](#3068)) ([1b0fd5d](1b0fd5d))
@parseplatformorg

Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 8.6.1-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 13, 2026
parseplatformorg pushed a commit that referenced this pull request Sep 23, 2026
## [8.6.1](8.6.0...8.6.1) (2026-09-23)

### Bug Fixes

* Bump ws from 8.20.0 to 8.21.0 ([#3068](#3068)) ([1b0fd5d](1b0fd5d))
@parseplatformorg

Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 8.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants