Repository navigation
Applying filters not working #1991
Description
New Issue Checklist
- I am not disclosing a vulnerability.
- I am not just asking a question.
- I have searched through existing issues.
- I can reproduce the issue with the latest versions of Parse Server and Parse Dashboard.
Issue Description
When filtering the data URL changes but the browser doesn't refresh. It doesn't matter if filters are applied from filters section or context menu.
Steps to reproduce
- Go to data browser;
- Click on "Filters";
- Click on "Apply these filters";
- Go to data browser;
- Right click on a cell with data;
- Click on a "Set filter...";
- Pick any option.
Actual Outcome
URL changes but nothing happens. Filter panel stays open.
Expected Outcome
Data browser should refresh and show filtered data. I believe in first scenario filters panel should also close.
Environment
Dashboard
- Parse Dashboard version:
4.0.0-beta.1 - Browser (Safari, Chrome, Firefox, Edge, etc.):
Chrome - Browser version:
97.0.4692.71
Server
- Parse Server version:
any - Operating system:
Linux - Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc):
Google Cloud
Database
- System (MongoDB or Postgres):
MongoDB - Database version:
latest - Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc):
MongoDB Atlas
Logs
Nothing gets logged in browser' dev tools.
Activity
parse-github-assistant commentedon Jan 12, 2022
Thanks for opening this issue!
mtrezza commentedon Jan 12, 2022
I was able to reproduce this issue in 4.0.0-beta.1 and 4.0.0-alpha.5.
404-html commentedon Jan 15, 2022
This looks like a general problem with reading query string params as opening parse dashboard URL that contains filtering have no effect.
mtrezza commentedon Jan 15, 2022
You could go back to see which PR introduced the issue. I suspect that is was a "refactor" PR that just made a minor dependency upgrade, but somehow is causing issues.
Unfortunately we do not have UI tests in dashboard to detect these issues before merging, and this is not the first time something like this happens. A few UI tests would be a big help in that regard.
404-html commentedon Jan 15, 2022
Git bisect pointed following commit: 1ff1057
[-]Applying filers not working[/-][+]Applying filers not working #easymoney[/+][-]Applying filers not working #easymoney[/-][+]Applying filers not working[/+]mtrezza commentedon Jan 21, 2022
@404-html There are a couple of similar looking issues where something in the UI is not working / has no effect:
In case of #2006 it started with version 3.3.0. Could you try to find out the earliest release that introduced the issue, so we can narrow down which commit introduced the issue.
404-html commentedon Jan 21, 2022
Hey @mtrezza, in my previous comment I pointed exact commit which introduced the issue.
mtrezza commentedon Jan 22, 2022
@visualfanatic since you have more insight into #1948, could you take a quick look at this issue here? it may be related to the React context API change, there are also a few similar new issues where an action in the UI has no effect, so I would assume it may be a
contextissue, which is one of the major changes in #1948.damianstasik commentedon Jan 22, 2022
@mtrezza There were some regressions caused by two of my recent refactors and I created a PR with fixes for the issues you mentioned.
[-]Applying filers not working[/-][+]Applying filters not working[/+]mtrezza commentedon Jan 23, 2022
Thanks @visualfanatic for the quick fix! I can confirm it fixes all 3 issues and I already merged the PR, released as
4.0.0-alpha-11.