Repository navigation
Add linting to repository #2467
Description
New Feature / Enhancement Checklist
- I am not disclosing a vulnerability.
- I am not just asking a question.
- I have searched through existing issues.
Current Limitation
The code is not (properly) linted, causing varying code styles.
Feature / Enhancement Description
Enforce proper lint rules.
Activity
parse-github-assistant commentedon Jun 19, 2023
Thanks for opening this issue!
patelmilanun commentedon Jun 19, 2023
I think for code style we should use something like prettier or any such code formatter. Doing formatting with linter is very bad idea mostly because of performance. I do have a video suggestion to not use linter as formatter. If u want I can post it here.
mtrezza commentedon Jun 19, 2023
We use both prettier and eslint as the default across repos in this org.
patelmilanun commentedon Jun 19, 2023
Basically we setup a prettier formatting step in our CI so when somebody is pushing code that is not formatted correctly our CI will yell at him.
patelmilanun commentedon Jun 19, 2023
I don't see prettier anywhere in the dashboard repo.
mtrezza commentedon Jun 19, 2023
You could look at the parse server repo for how we use eslint and prettier:
check-lint)patelmilanun commentedon Jun 19, 2023
ok but we dont have a dedicated step for checking formatting right ? or linter is doing that?
mtrezza commentedon Jun 19, 2023
Yes, it's in the CI, see the 2nd point
mtrezza commentedon Jun 19, 2023
Dashboard already has a lint check in the CI, see
https://github.com/parse-community/parse-dashboard/actions/runs/5315803113/jobs/9624609903?pr=2463
But it seems the rules are different, because it doesn't seem to enforce leading spacing and code structure for example:
#2466 (comment)
I would compare the lint rules with those of parse sever, which are the best maintained of all repos I assume.