Repository navigation
SchemaController.getAllClasses accepts parameter with wrong type #7677
Description
New Issue Checklist
- I am not disclosing a vulnerability.
- I am not just asking a question.
- I have searched through existing issues.
- I can reproduce the issue with the latest version of Parse Server.
Issue Description
When I was reading the source code, I found two mistakes when calling SchemaController.getAllClasses.
getAllClasses accepts a object with a key named clearCache.
getAllClasses(options: LoadSchemaOptions = { clearCache: false })
But there are two places calling this function with a boolean value.
No.1
In src/Routers/SchemasRouter.js#L19
function getAllSchemas(req) {
return req.config.database
.loadSchema({ clearCache: true })
.then(schemaController => schemaController.getAllClasses(true)) // => #L19
.then(schemas => ({ response: { results: schemas } }));
}No.2
In /src/GraphQL/loaders/schemaQueries.js#L63
const schema = await config.database.loadSchema({ clearCache: true });
return (await schema.getAllClasses(true)).map(parseClass => ({ // => #L63
name: parseClass.className,
schemaFields: transformToGraphQL(parseClass.fields),
}));Environment
Server
- Parse Server version: 5.0.0-beta.1
Logs
n/a
Activity
parse-github-assistant commentedon Nov 4, 2021
Thanks for opening this issue!
mtrezza commentedon Nov 4, 2021
It seems you are correct; in 0a6eaf3 the bool has been replaced by object, but the lines you mentioned seem to have been forgotten while others were converted.
What was the potential impact of that? Tests usually pass.
ThornWu commentedon Nov 5, 2021
When our team switch our deploy method from
docker-composetohelm chart（with a single pod）, we found the hot reload of schema is broken. The database is updated, but the schema cache not. Then I foundGET /schemasseems to designed for getting the newest schema by refreshing cache, so I was going to call this router manually. The only thing I need to first is adding a patch to the functiongetAllSchemas. I did it and it was working.Currently I have no time to find the exact reason why the
helm chartway is broken, but I ensure all PARSE config are same.So the actual problem I met is in some case, schema cache doesn't refresh. I just bypassed the problem and found these two mistakes.