Repository navigation
Parse.User.requestEmailVerification fails with code -1 when user is already verified #7740
Description
New Issue Checklist
- [ x] I am not disclosing a vulnerability.
- [ x] I am not just asking a question.
- [ x] I have searched through existing issues.
- [ x] I can reproduce the issue with the latest version of Parse Server.
Issue Description
A specific error code when the email verification fails when the user is already verified
Steps to reproduce
call Parse.User.requestEmailVerification when user is already verified
Actual Outcome
{"code":-1,"stack":"Error: Email anmphfnejxtxzkilwb@kvhrw.com is already verified"}
Expected Outcome
A better error code instead of -1
should have message instead of stackproperty?
Environment
Server
- Parse Server version: "^5.0.0-beta.4",
- Operating system: macos
- Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local
Database
- System (MongoDB or Postgres):
MongoDB
Activity
parse-github-assistant commentedon Dec 13, 2021
Thanks for opening this issue!
pash2048 commentedon Dec 22, 2021
Hi @mtrezza , May I work on this?
mtrezza commentedon Dec 22, 2021
@pash2048 sure, please go ahead. I guess the first step would be to identify a better cloud code error number. I suggest you take a look at the Parse Error section in the contribution guide.
I reclassified this as
featuresince it's a feature related improvement rather than a bug.pash2048 commentedon Dec 23, 2021
Dear @mtrezza , thanks for the opportunity. Very cool. Thumbs up!
at the first, I need to send a pr to parse js SDK for a new Error code after merged change Parse JS SDK dependency in package.json of Parse Server and throw new Parse.Error with those error code in /src/Routes/UsersRouter.js.
everything is alright?
mtrezza commentedon Dec 24, 2021
Sounds good. For the Parse Server PR: changing the error code is a breaking change. We need to deprecate the old error code with a temporary server option to switch to the new error code. According to our deprecation policy, the new error code will be used by default in Parse Server 7 (2023).
pash2048 commentedon Dec 24, 2021
I did not figure out how I deprecate the old error code with a temporary server option to switch to the new error code. Can you please give me a hint?
mtrezza commentedon Dec 26, 2021
Sure, please see the contribution guide for how to deprecate a feature and how to add a parse server option.
For each of these there are existing usages in code where you can see how it's implemented.