Repository navigation
Add ability to disable authentication adapter #7952
Description
New Feature / Enhancement Checklist
- I am not disclosing a vulnerability.
- I am not just asking a question.
- I have searched through existing issues.
Current Limitation
Currently, all internal auth adapters are enabled by default, with no option to disable auth adapters that aren't necessary.
Feature / Enhancement Description
Allow
auth : {
facebook: {
enabled: false
}
}
Example Use Case
n/a
Alternatives / Workarounds
n/a
3rd Party References
n/a
Activity
parse-github-assistant commentedon Apr 26, 2022
Thanks for opening this issue!
mtrezza commentedon Apr 26, 2022
Do we need a separate property for this or just disable them if they are not configured in the Parse Server options? Maybe we can make this breaking change in the future and add the option only temporarily, already with a depreciation warning?
dblythy commentedon Apr 27, 2022
That's what I was thinking. Disabling them if they are not configured would be a breaking change. Many auth adapters however don't require any backend configuration and depend fully on client side. Perhaps we can make a change:
auth.facebook) consider them enabledauth.google.enabledto be enabled.This still would be a breaking change, however I think it's one worth pushing through.
mtrezza commentedon Apr 27, 2022
If not every adapter requires server configuration then I guess it doesn't work to only enable them if they are configured server side. I think your suggestion makes most sense to introduce an
enabledproperty that is currentlytrueby default (with a deprecation warning), and then we change this in a later version tofalseby default so one has to manually enable them - for security.dblythy commentedon Apr 27, 2022
Sounds good!
mtrezza commentedon May 28, 2022
Closing via #7953