LiveQueryServer crashes when configured to run with Redis cacheAdapter #9432

Activity

1. parse-github-assistant commented on Nov 13, 2024

   

   parse-github-assistantBot

   on Nov 13, 2024 – with Parse GitHub Assistant

   More actions

   Thanks for opening this issue!
2. evtimmy commented on Nov 13, 2024

   

   evtimmy

   on Nov 13, 2024

   Author

   More actions

   I did debug the initialization of the server and saw that ParseLiveQueryServer creates its own cacheController instance:

   parse-server/src/LiveQuery/ParseLiveQueryServer.js

   Line 62 in 91f9aca

   this.cacheController = getCacheController(parseServerConfig);

   but that instance connect() is never called. The regular ParseServer does call connect() on its own instance of the cache when initializing the startup promises.

   This used to work in earlier versions of parse-server, before we switched to redis 4 client as redis 4 requires the async connect() to be explicitly called before using the client, whereas redis 3 automatically called connect() if the client was not connected.

   One simple fix would be to add initialization await this.cacheController.connect() here:

   parse-server/src/LiveQuery/ParseLiveQueryServer.js

   Lines 84 to 94 in 91f9aca

   	async connect() {
   	if (this.subscriber.isOpen) {
   	return;
   	}
   	if (typeof this.subscriber.connect === 'function') {
   	await Promise.resolve(this.subscriber.connect());
   	} else {
   	this.subscriber.isOpen = true;
   	}
   	this._createSubscribers();
   	}

   I'm just not clear on why we check this.subscriber.isOpen and if this connect() may be called multiple times, or only on startup?
3. mtrezza

   added

   type:bugImpaired feature or lacking behavior that is likely assumedImpaired feature or lacking behavior that is likely assumed

   on Nov 14, 2024
4. Chilldev commented on Jan 26, 2025

   

   Chilldev

   on Jan 26, 2025

   Last edited by Chilldev

   Contributor

   More actions

   The crash is coming from:

   parse-server/src/Adapters/PubSub/RedisPubSub.js

   Lines 1 to 11 in 5ca0aa3

   	import { createClient } from 'redis';
   	function createPublisher({ redisURL, redisOptions = {} }): any {
   	redisOptions.no_ready_check = true;
   	return createClient({ url: redisURL, ...redisOptions });
   	}
   	function createSubscriber({ redisURL, redisOptions = {} }): any {
   	redisOptions.no_ready_check = true;
   	return createClient({ url: redisURL, ...redisOptions });
   	}

   Connections do not have an error handler.
   In my case it was happening when redis crashed unexpectdly or was unreachable.

   I am not sure if this issue is related:
   redis/node-redis#2624

   I created a patch to listen to connection errors and the server is no longer crashing.

   import { logger } from '../../logger';
   
   function createPublisher({ redisURL, redisOptions = {} }): any {
     redisOptions.no_ready_check = true;
     const client = createClient({ url: redisURL, ...redisOptions });
     client.on('error', (err) => {
       logger.error('RedisPubSub publisher client error', {
         error: err
       });
     });
     return client;
   }
   
   function createSubscriber({ redisURL, redisOptions = {} }): any {
     redisOptions.no_ready_check = true;
     const client = createClient({ url: redisURL, ...redisOptions });
     client.on('error', (err) => {
       logger.error('RedisPubSub subscriber client error', {
         error: err
       });
     });
     return client;
   }
5. gcarpi commented on Feb 13, 2025

   

   gcarpi

   on Feb 13, 2025

   More actions

   Any update? I need this fix
6. mtrezza

   added

   bounty:$20Bounty applies for fixing this issue (Parse Bounty Program)Bounty applies for fixing this issue (Parse Bounty Program)

   on Feb 13, 2025
7. mtrezza

   linked a pull request that will close this issuefix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server #9615on Feb 22, 2025
8. mtrezza

   closed this as completedin #9616on Feb 24, 2025
9. parseplatformorg commented on Feb 24, 2025

   

   parseplatformorg

   on Feb 24, 2025

   Contributor

   More actions

   🎉 This change has been released in version 8.0.0-alpha.12
10. parseplatformorg

    added

    state:released-alphaReleased as alpha versionReleased as alpha version

    on Feb 24, 2025
11. parseplatformorg commented on Mar 12, 2025

    

    parseplatformorg

    on Mar 12, 2025

    Contributor

    More actions

    🎉 This change has been released in version 7.5.0
12. parseplatformorg

    added

    state:released-7.x.xReleased as LTS versionReleased as LTS version

    on Mar 12, 2025