Repository navigation
refactor: Remove unused lint-staged dependency and husky configuration - #10673
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change removes Changeslint-staged removal
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The cleanup does not leave a broken install, hook, or workflow reference and is ready to merge. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10673 +/- ##
==========================================
+ Coverage 93.82% 93.83% +0.01%
==========================================
Files 192 192
Lines 16882 16882
Branches 252 252
==========================================
+ Hits 15840 15842 +2
+ Misses 1020 1018 -2
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
11b21ef to
c60dfc3
Compare
c60dfc3 to
b3373a7
Compare
|
🎉 This change has been released in version 9.10.1-alpha.19 |
|
🎉 This change has been released in version 9.10.1 |
Issue
lint-stagedis declared as a devDependency and configured inpackage.json, but nothing in the repository ever runs it.huskywas removed as an unused dependency in perf: Remove unused dependencies #9943 (perf: Remove unused dependencies), which droppedhusky,flow-bin,graphql-tag,routerand@babel/eslint-parser— but leftlint-stagedand its configuration behind..husky/directory, and there was none even before perf: Remove unused dependencies #9943.lint-staged(prepareisnpm run build).grep -c lint-stagedreturns0for both.github/workflows/ci.ymlandrelease-automated.yml.lint-stagedmatches onlypackage.jsonitself.The leftover
huskykey is also stale in its own right. It uses the v4husky.hooksformat:That format has not been supported since husky v5 (2021), so the hook was already inert even while husky 9.x was still installed.
The practical consequence is recurring maintenance noise: Dependabot keeps proposing
lint-stagedupgrades (#10595 proposes 17.2.0) for a tool that cannot execute.lint-staged@17additionally raisesengines.nodeto>=22.22.1, which conflicts with this project's>=20.19.0 <21.0.0 || >=22.13.0 <23.0.0 || >=24.11.0 <25.0.0, so accepting that bump would introduce an engine conflict purely to maintain dead configuration.Closes #10595
Approach
Remove the
lint-stageddevDependency and both orphanedpackage.jsonkeys (huskyandlint-staged), completing the cleanup started in #9943.package.jsonandpackage-lock.jsononly; no source changes.Breaking Changes
None. The removed tooling was not reachable from any script, hook or workflow.
Notes
lint-stagedplus its tree:listr2,log-update,cli-truncate,slice-ansi,string-argv,tinyexec,rfdc,coloretteand nested copies). No package is added, and every removed entry was alreadydev: true— no production dependency is affected.prettier(3.8.1) andeslint(9.27.0) are unaffected; they are separate devDependencies with their ownprettier,lintandlint-fixscripts. Only the unused pre-commit wiring that referenced them is removed.husky, add apreparehook and a.husky/pre-commitfile — rather than keeping configuration that no longer has a runner.Verified locally:
npm run lintclean,npm run buildcompiles 197 files,npm run ci:definitionsCheckpasses.Tasks
Summary by CodeRabbit