Repository navigation
Fail action when PR is not mergeable - #177
Conversation
|
The circleci failures we're seeing here seem unrelated to my changes. |
|
The CircleCI error seems like a known error that can be fixed via a node option flag |
|
The CircleCI error should be fixed via updating the node version, could you rebase the branch? |
|
@pascalgn thanks for the tip, that worked! 🎉 |
|
@pascalgn anything that I can do to help get this over the line? |
|
@pascalgn Friendly reminder about this PR 🙂 We use this action heavily in our CI but the fact that it fails silently is a pain point we would love to resolve. |
|
Hi @pascalgn Any updates/idea if this feature could be shipped? Thanks! |
be28fa3 to
a696b87
Compare
a696b87 to
8d853da
Compare
|
Thanks for the PR, it's merged now! It took some more time, because I had to put this behaviour behind a new option (MERGE_ERROR_FAIL), to not break existing workflows. Thanks! 🚀 |
Hello @pascalgn 👋
Coming from this comment – this action fails silently when the pull request fails to merge. Instead, the action should exit with a non-zero exit code so that the workflow can properly handle the failure.
This PR does that by introducing a
failmethod which usescore.setFailedto set an error message andprocess.exit(1)to fail the action.The change is covered by an automated unit test.