build(package.json): Upgrade react-bootstrap to fix React deprecated lifecycle method warnings#3249
Merged
Merged
Conversation
mturley
changed the title
mturley
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3249 +/- ##
=======================================
Coverage 67.43% 67.43%
=======================================
Files 892 892
Lines 24869 24869
Branches 2140 2140
=======================================
Hits 16770 16770
Misses 7094 7094
Partials 1005 1005
Continue to review full report at Codecov.
|
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3249.surge.sh |
mturley
force-pushed
the
3010-fix-lifecycle-warnings
branch
from
October 30, 2019 22:43
6d5d402 to
6b36dd8
Compare
Contributor
Author
|
Looks like this needs fixes to our in-house components, too. Don't merge just yet. #3010 (comment) |
Contributor
Author
|
Scratch that last comment, #3098 resolved the issues @martinpovolny identified. This should be good to merge. I'll give it a rebase now. |
mturley
force-pushed
the
3010-fix-lifecycle-warnings
branch
from
November 4, 2019 12:48
6b36dd8 to
e26d4df
Compare
Contributor
Author
|
Rebased. @redallen could you re-approve? |
dlabrecq
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fixes #3010
In order to prevent React's warnings about deprecated lifecycle methods, and allow consumers who use Patternfly 3 components to eventually upgrade to React 17, I am upgrading our version of react-bootstrap to take their fixes for react-bootstrap/react-bootstrap#4398.
Additional issues:
Once released, this will unblock ManageIQ/manageiq-v2v#1037.
We should do a once-over to make sure all affected PF3 components are still behaving as expected, especially since some of the snapshots changed.