fix(Dropdown): Apply pf-m-plain modifier to dropdown toggle element instead of wrapper#954
Merged
Conversation
Pull Request Test Coverage Report for Build 3400
💛 - Coveralls |
jschuler
suggested changes
Nov 26, 2018
jschuler
left a comment
jschuler
left a comment
Contributor
There was a problem hiding this comment.
Can you also update the props in the typescript definition files?
Contributor
Author
|
@jschuler Will do. Also, this is my first PR to pf-react. I seem to have missed a step to update the test snapshots. What is the process for that? |
Contributor
|
@TheRealJon |
Collaborator
|
PatternFly-React preview: https://954-pr-patternfly-react-patternfly.surge.sh |
Contributor
Author
|
@jschuler Fixed the snapshots and the type declarations. |
jschuler
previously approved these changes
Nov 28, 2018
Contributor
Author
|
@jschuler Just rebased and updated snapshots. Should be good to go once CI finishes. |
… instead of wrapper
jschuler
approved these changes
Nov 28, 2018
Contributor
Author
|
@jschuler Who else should I ping to get approval on this? |
kmcfaul
approved these changes
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #953.