Repository navigation
Implement job cancelation feature - #77
Merged
Will Graham (wlggraham) merged 6 commits intoJan 22, 2026
Merged
Will Graham (wlggraham) merged 6 commits into
Will Graham (wlggraham) merged 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements a job cancellation feature that enables users to cancel running jobs from the job details page. The implementation includes backend API integration, UI components with loading states, and toast notifications for user feedback.
Key changes:
- Added backend API integration with a new
cancelJobfunction to handle POST requests for job cancellation - Implemented a "Cancel Job" button in the job details page with React Query mutation, conditional enabling based on job status, and loading state display
- Added global toast notification container to provide user feedback for cancellation operations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| web/src/app/api/jobs/jobs.ts | Added cancelJob API function to send POST requests to the job cancellation endpoint |
| web/src/modules/Jobs/JobDetails/JobDetailsHeader.tsx | Integrated cancel mutation with React Query, added cancel button with conditional enabling, implemented toast notifications for success/error states, and included minor JSX formatting improvements |
| web/src/common/ClientLayout/ClientLayout.tsx | Added PatternToastContainer component to enable global toast notifications throughout the application |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Will Graham (wlggraham)
previously approved these changes
Jan 7, 2026
Co-authored-by: Josh Diaz <joshua.michael.diaz@gmail.com>
Co-authored-by: Josh Diaz <joshua.michael.diaz@gmail.com>
Josh Diaz (JoshMDiaz)
previously approved these changes
Jan 8, 2026
Will Graham (wlggraham)
deleted the
CU-86dz3vyw4_Add-Job-cancelation-feature-in-heimdall
branch
January 22, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability for users to cancel running jobs from the job details page and improves user feedback with toast notifications. The changes include backend API integration, UI enhancements, and improved state management for job cancellation.
Job Cancellation Feature:
cancelJobAPI function injobs.tsto send a POST request to cancel a job by its ID.JobDetailsHeader.tsx, which uses React Query's mutation to call the cancel API, disables the button unless the job is running, and displays "Cancelling..." while the request is pending.UI/UX Improvements:
PatternToastContainerto the app layout to ensure toast notifications are displayed globally.