Version 2.4.0 breaks pear/xml_rpc2 1.1.4 #18

Activity

1. sad-spirit commented on Jul 28, 2020

   

   sad-spirit

   on Jul 28, 2020

   Member

   More actions

   Any hint to solve this?

   Basically, just remove require_once 'HTTP/Request2.php' statement from the above file.

   The longer answer is that I removed include-path setting from composer.json of release 2.4.0, so packages that depend on HTTP_Request2 can no longer rely on the fact that such statements work. They should only do this as a fallback if the class was not autoloaded, e.g.

   if (!class_exists('HTTP_Request2', true)) {
       require_once 'HTTP/Request2.php';
   }

   the code above will trigger autoloading when run from composer installation and fall back to explicit require in PEAR installation.

   Please open an issue for xml_rpc2 linking to this one
2. sad-spirit

   closed this as completedon Jul 28, 2020
3. sad-spirit

   pinned this issue on Jul 28, 2020
4. aguvillalba commented on Jul 28, 2020

   

   aguvillalba

   on Jul 28, 2020

   Author

   More actions

   Thank you very much! I've created a pull request to xml_rpc2.

   👍React with 👍1Reacted by Pavel Kalbovich