Skip to content

fix(mobile): gate driveto()'s per-step print behind verbose flag#550

Merged
petercorke merged 1 commit into
mainfrom
fix/driveto-unconditional-print
Jul 20, 2026
Merged

fix(mobile): gate driveto()'s per-step print behind verbose flag#550
petercorke merged 1 commit into
mainfrom
fix/driveto-unconditional-print

Conversation

@petercorke

Copy link
Copy Markdown
Owner

Summary

VehicleDriverBase.driveto() prints an unconditional status line on every call — any simulation longer than a couple of steps floods stdout. RandomPath._new_goal() right below it already gates its print behind self._veh.verbose or self._verbose; driveto() just never got the same treatment. Found while building a working EKF/RandomPath example for a docs update.

Test plan

  • Ran a 20s EKF dead-reckoning simulation (Bicycle + RandomPath) — clean output, no per-step spam
  • Full test suite: 653 passed, 13 skipped, no regressions

🤖 Generated with Claude Code

VehicleDriverBase.driveto() printed an unconditional status line on
every call, unlike RandomPath._new_goal() right below it which
correctly gates its print behind self._veh.verbose or self._verbose.
Any simulation of more than a few steps floods stdout -- found while
building a runblock example for docs/source/intro.rst's planned Mobile
Robots section.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@petercorke
petercorke force-pushed the fix/driveto-unconditional-print branch from 42a75f2 to 2115bb3 Compare July 20, 2026 05:29
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (48715b3) to head (2115bb3).

Files with missing lines Patch % Lines
src/roboticstoolbox/mobile/drivers.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #550   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        141     141           
  Lines      13659   13660    +1     
=====================================
- Misses     13659   13660    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petercorke
petercorke merged commit aac83e1 into main Jul 20, 2026
18 checks passed
@petercorke
petercorke deleted the fix/driveto-unconditional-print branch July 20, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant