feat: support fetching a REF_CURSOR using getObject - #809
Merged
Merged
Conversation
marschall
force-pushed
the
ref-cursor-getObject
branch
from
April 8, 2017 15:10
c1d6aa7 to
c4516d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
============================================
+ Coverage 65.26% 65.29% +0.03%
- Complexity 3518 3522 +4
============================================
Files 166 166
Lines 15226 15228 +2
Branches 2466 2466
============================================
+ Hits 9937 9943 +6
+ Misses 4100 4098 -2
+ Partials 1189 1187 -2Continue to review full report at Codecov.
|
Since DatabaseMetaData#supportsRefCursors now reports true frameworks like Hibernate now use callableStatement.getObject(int, ResultSet.class) to fetch the REF_CURSOR. Only support ResultSet.class as an argument to keep the patch simple. Closes: pgjdbc#794
marschall
force-pushed
the
ref-cursor-getObject
branch
from
April 8, 2017 18:30
c4516d1 to
50428a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since DatabaseMetaData#supportsRefCursors now reports true
frameworks like Hibernate now use
callableStatement.getObject(int, ResultSet.class) to fetch the
REF_CURSOR.
Only support ResultSet.class as an argument to keep the patch simple.
Closes: #794