Preserve reload worker failure exit status - #372
Open
hansu650 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269.
When a reloaded worker failed (for example, while importing an application with a new syntax error),
un() initially captured its non-zero exit code and removed the failed process. The final cleanup then called _join_exited() again on the now-empty process list and assigned its zero result back to �xitcode, so the CLI reported success.
This keeps the cleanup join but preserves the already-recorded failure code. The regression test models a clean initial worker reload followed by a replacement worker exiting with status 1.
Validation:
The full Windows test run reaches 190 passed with 7 unrelated baseline failures in Unix-only socket/path tests, e2e binding, and HTTP/2 CONNECT validation against the latest h2.