ext/phar: Fix .phar-prefixed non-magic directory handling - #22372
Closed
LamentXU123 wants to merge 1 commit into
Closed
ext/phar: Fix .phar-prefixed non-magic directory handling#22372LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
Girgias
requested changes
Jun 23, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Considering long term all those paths should ideally be zend_strings I don't want a long name for it. And using an _ex suffix is quite common.
Co-authored-by: George Peter Banyard <girgias@php.net>
LamentXU123
marked this pull request as draft
June 23, 2026 09:45
LamentXU123
force-pushed
the
phar-rebranch-on-8.4
branch
from
June 23, 2026 09:46
10880f9 to
ea7fe0b
Compare
LamentXU123
marked this pull request as ready for review
June 23, 2026 09:47
Member
Author
|
Fixed :) I am wondering how to write NEWS for this one. |
Girgias
approved these changes
Jun 23, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
NEWS file looks good to me. Careful when merging up as some pointers might have become zend_strings.
LamentXU123
added a commit
that referenced
this pull request
Jun 23, 2026
* PHP-8.5: ext/phar: Fix .phar-prefixed non-magic directory handling (#22372)
Member
Author
|
Indeed. You might need to review the commits to upper branches after I push them to make sure everything works :) Thanks |
pull Bot
pushed a commit
to dolfly/php-src
that referenced
this pull request
Jun 23, 2026
* PHP-8.4: ext/phar: Fix .phar-prefixed non-magic directory handling (php#22372)
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
Use a shared helper for checking whether a path refers to the magic .phar directory. Treat .phar itself and paths below it as magic, while allowing non-magic entries that merely use a .phar-prefixed name such as .pharx. Apply the same check across creation, copying, ArrayAccess, stream lookup, directory iteration, extraction, and mounts so these paths are handled consistently. Co-authored-by: Gina Peter Banyard <girgias@php.net> Closes php#22372
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
* PHP-8.4: ext/phar: Fix .phar-prefixed non-magic directory handling (php#22372)
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
* PHP-8.5: ext/phar: Fix .phar-prefixed non-magic directory handling (php#22372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Girgias :). Improved these logic by writing the
phar_path_is_magic_pharhelper as planned in #22011